[fix] mcp_servers/browser: Remove clear-text password from login response#126
Open
RinZ27 wants to merge 1 commit intojd-opensource:mainfrom
Open
[fix] mcp_servers/browser: Remove clear-text password from login response#126RinZ27 wants to merge 1 commit intojd-opensource:mainfrom
RinZ27 wants to merge 1 commit intojd-opensource:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
browser_auto_logintool currently returns the rawlogin_passwordin its final response dictionary. This results in sensitive credentials being exposed in session logs and chat history within the MCP environment.Related Issue(s)
Changes
Removed the
login_passwordfield from the result dictionary inbrowser_auto_loginto ensure passwords don't leak into the console or logs.Checklist