Skip to content

fix: call detect_bulb() in *_percentage() methods before reading value_max #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonacox-sam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: call detect_bulb() in *_percentage() methods before reading value_max #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tinytuya/BulbDevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,9 @@ def set_white_percentage(self, brightness=100, colourtemp=0, nowait=False):
if err:
raise ValueError( 'set_white_percentage: %s percentage needs to be between 0 and 100.' % err[1:])

if not self.bulb_configured:
self.detect_bulb(nowait=nowait)

b = int(self.dpset['value_max'] * brightness // 100)
c = int(self.dpset['value_max'] * colourtemp // 100)

Expand Down Expand Up @@ -656,6 +659,8 @@ def set_brightness_percentage(self, brightness=100, nowait=False):
"""
if not 0 <= brightness <= 100:
raise ValueError('set_brightness_percentage: The brightness needs to be between 0 and 100.')
if not self.bulb_configured:
self.detect_bulb(nowait=nowait)
b = int(self.dpset['value_max'] * brightness // 100)
return self.set_brightness(b, nowait=nowait)

Expand Down Expand Up @@ -704,6 +709,8 @@ def set_colourtemp_percentage(self, colourtemp=100, nowait=False):
"""
if not 0 <= colourtemp <= 100:
raise ValueError( 'set_colourtemp_percentage: Colourtemp percentage needs to be between 0 and 100.')
if not self.bulb_configured:
self.detect_bulb(nowait=nowait)
c = int(self.dpset['value_max'] * colourtemp // 100)
return self.set_colourtemp( c, nowait=nowait )

Expand Down
Loading