Conversation
Member
Author
|
I’ve just added minimal documentation & rephrased the commit message. |
eponier
previously approved these changes
Feb 20, 2026
eponier
left a comment
eponier
left a comment
Contributor
There was a problem hiding this comment.
I didn't spot anything fishy, except the extraction to EasyCrypt and the safety checker which are both future work I believe.
I have just some minor comments on remove_assert.v.
vbgl
force-pushed
the
cassert
branch
2 times, most recently
from
February 21, 2026 04:48
23fe4fd to
e5b0be8
Compare
Assertions can be written in Jasmin programs as
assert("label", b);
where `"label"` is an informative string literal and `b` a boolean
expression.
In the source semantics, they evaluate their argument `b` and fail if it
is not true; do nothing otherwise.
Those assertions are mostly meant to be used internally. A very early
compilation pass removes these assertions.
Co-authored-by: Vincent Laporte <Vincent.Laporte@inria.fr>
eponier
approved these changes
Feb 23, 2026
eponier
left a comment
eponier
left a comment
Contributor
There was a problem hiding this comment.
There is now even some support in the safety checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR have been extracted from #1170.
Assertions can be written in Jasmin programs as
where
"label"is an informative string literal andba booleanexpression.
At run-time, they evaluate their argument
band fail if it is nottrue; do nothing otherwise.
Those assertions are mostly meant to be used internally. A very early
compilation pass removes these assertions.
Checklist
changesif the PR is a user-visible changecompiler/testsif it makes sense, especially if it is a bug fixExtraction to EasyCrypt (TODO in
toEC.ml) is intentionally left as future work.Should this be more documented?