Parser: remove redundant rule for strings in attributes & other fixes - #1376
Merged
Conversation
Arrays are not allowed as values of attributes.
vbgl
changed the title
eponier
approved these changes
Feb 5, 2026
eponier
left a comment
eponier
left a comment
Contributor
There was a problem hiding this comment.
Alternative solutions do not seem really better.
- Changing the syntax of array literals: a lot of code using them + using the syntax of Rust (
[1, 2, 3]) would conflict with memory accesses. - Changing the syntax of structured annotations: it would be possible, but natural separators (
(and[) would certainly create conflicts too.
If, in the future, we realize that we need arrays in annotations, we can reintroduce them (e.g. by requiring mandatory parentheses around array literals or something similar).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix after #1375.
There is an other parsing issue with arrays in attributes.