Fix listeners leak when using with componentDidCatch#52
Open
SamyPesse wants to merge 5 commits intojamiebuilds:masterfrom
Open
Fix listeners leak when using with componentDidCatch#52SamyPesse wants to merge 5 commits intojamiebuilds:masterfrom
SamyPesse wants to merge 5 commits intojamiebuilds:masterfrom
Conversation
SamyPesse
commented
Aug 29, 2018
| export class Subscribe<Containers: ContainersType> extends React.Component< | ||
| SubscribeProps<Containers>, | ||
| SubscribeState | ||
| class SubscribeUpdater<Containers: ContainersType> extends React.Component< |
Author
There was a problem hiding this comment.
I'm not a big fan of splitting the Subscribe component in two components, but because of the context API, it looked like the cleaner method to handle the lifecycle of the instances (subscribe to new instances, unsubscribe from previous one when it render, etc).
Author
|
This solution is not working, because it changes the order of listeners (child component subscribe before the parent does). I'm gonna investigate other solutions... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've investigated a bug in my application coming from the use of
unstatedandcomponentDidCatch.At some point
container.setStatewas returning a never-fulfilled promise. React was logging:When an error is thrown during the render phase, the
componentWillUnmountis never called, and the component doesn't unsubscribe from the container.When calling
setState, since the component for the listener is unmounted,onUpdatereturns a never-fulfilled promise.Potential solution: I'm experimenting moving the subscribe calls to a safe place
componentDidMount(which happens during the commit phase, see this comment that explains it).Any way, I'd love to get your feedback on what could be the best approach to fix this 🙌
TLDR: When using
unstatedwithcomponentDidCatch, it leaks listeners, and preventsetStatefrom being fulfilled.