-
Notifications
You must be signed in to change notification settings - Fork 0
DO NOT DELETE nor CLOSE: PR base:main <- compare: sps-test-main #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 7 commits
9243d08
16d6533
f13953c
90bf9c9
0ff02ce
2c221c7
7343d5b
714c3ee
c57702e
405cdc5
3d616c7
0ce8a3a
04a7b2f
5134e50
1298741
212ae0f
e2528ef
9fab506
c7f4d61
95c7d3a
87d7fc5
794e8da
d37040e
4c2e2e4
334202c
45bb3ab
50b3d24
098418c
fbaf98d
2c40547
9c6282d
db7c4e8
b9ecf23
2165f32
9b5cfa4
115aaef
b3134f2
9912d36
0aee285
5d73a4a
b2e0f84
700cfde
d18a557
69f8508
64e834a
e5d560b
95a9fb0
dbe7cef
f09a670
b4edbc2
1d858ab
94fd488
a6cd790
67d9124
0505933
aecbe90
6b412c8
9cf11cc
cc97034
3922de2
de4cd2b
bac5839
9523cf0
704820f
6931ccf
a109776
6f4970f
5c0e8ac
ab49d36
d3114d3
b878258
e7d9f80
887fec6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,14 +5,17 @@ | |
| # Runs on pushes to any branch when changes are made to docs or workflow | ||
| push: | ||
| branches: | ||
| - main | ||
| - sps-test-main | ||
| paths: | ||
| - "docs/**" | ||
| - ".github/workflows/deploy-docs.yml" | ||
|
Comment on lines
+8
to
11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win Do not authorize Pages deployment from the test branch unintentionally. Pushes to 🤖 Prompt for AI Agents |
||
| pull_request: | ||
| paths: | ||
| - "docs/**" | ||
| - ".github/workflows/deploy-docs.yml" | ||
| schedule: | ||
| - cron: "25 4 * * 1-5" | ||
| timezone: "Europe/Berlin" | ||
|
|
||
| jobs: | ||
| deploy-docs: | ||
|
|
@@ -25,3 +28,15 @@ | |
| - uses: it-at-m/lhm_actions/action-templates/actions/action-build-docs@798bbf171750a308ece31e0ee7257b766888ccdc # v1.2.2 | ||
| # Only deploy documentation from the main branch to prevent unauthorized changes | ||
| - uses: it-at-m/lhm_actions/action-templates/actions/action-deploy-docs@798bbf171750a308ece31e0ee7257b766888ccdc # v1.2.2 | ||
|
|
||
| handlefailure: | ||
| needs: | ||
| - deploy-docs | ||
| runs-on: ubuntu-latest | ||
| if: failure() | ||
| steps: | ||
| - name: Notify Webex | ||
| run: | | ||
| curl -X POST -H "Content-Type: application/json" \ | ||
| -d '{"markdown" : "${{ github.server_url }}/${{ github.repository }} ${{ github.workflow }} failed"}' \ | ||
| "https://webexapis.com/v1/webhooks/incoming/${{ secrets.WEBEX_TOKEN }}" | ||
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
|
||
|
ejcsid marked this conversation as resolved.
Dismissed
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,10 @@ | |
| options: # Add or modify paths according to your project structure | ||
| - frontend | ||
| - webcomponent | ||
|
|
||
| schedule: | ||
| - cron: '30 5 * * 1-5' | ||
| timezone: "America/New_York" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: sed -n '1,120p' .github/workflows/release-npm.yml && printf '\n---\n' && rg -n "Europe/Berlin|America/New_York|timezone:" .github/workflows . -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**'Repository: it-at-m/sps-test Length of output: 3988 Use the agreed schedule timezone. 🧰 Tools🪛 zizmor (1.26.1)[warning] 4-25: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting (concurrency-limits) 🤖 Prompt for AI Agents🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: sed -n '1,220p' .github/workflows/release-npm.ymlRepository: it-at-m/sps-test Length of output: 3174 🏁 Script executed: rg -n "Europe/Berlin|America/New_York|timezone|release-npm" .github README* docs* . 2>/dev/nullRepository: it-at-m/sps-test Length of output: 2044 🌐 Web query:
💡 Result: GitHub Actions supports a timezone field within the schedule event trigger, allowing workflows to run based on a specified IANA timezone rather than defaulting to UTC [1][2][3]. Schedule Event Timezone Support: - You can specify a timezone using an IANA timezone string (e.g., "America/New_York") alongside your POSIX cron expression [1][2]. - This feature allows for timezone-aware scheduling, including proper handling of daylight saving time transitions [1][2]. - Example configuration: on: schedule: - cron: '30 5 * * 1-5' timezone: "America/New_York" Workflow_dispatch Contexts: - Workflows triggered by workflow_dispatch can access inputs provided during the trigger event [4][5]. - The recommended way to access these values is through the Citations:
🏁 Script executed: rg -n "use-pr|release-version|app-path|workflow_dispatch|schedule" .github/workflows . 2>/dev/nullRepository: it-at-m/sps-test Length of output: 3101 🌐 Web query:
💡 Result: In GitHub Actions, the Citations:
Guard the cron trigger or pass fixed values. 🧰 Tools🪛 zizmor (1.26.1)[warning] 4-25: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting (concurrency-limits) 🤖 Prompt for AI Agents |
||
|
|
||
| jobs: | ||
| release-npm-artifact: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -76,3 +79,17 @@ | |
| with: | ||
| artifact-name: ${{ needs.release-npm-artifact.outputs.ARTIFACT_NAME }} | ||
| tag-name: ${{ inputs.app-path }}-${{ needs.release-npm-artifact.outputs.ARTIFACT_VERSION }} | ||
|
|
||
| handlefailure: | ||
| needs: | ||
| - release-npm-artifact | ||
| - release-npm-image | ||
| - release-npm-github | ||
| runs-on: ubuntu-latest | ||
| if: failure() | ||
| steps: | ||
| - name: Notify Webex | ||
| run: | | ||
| curl -X POST -H "Content-Type: application/json" \ | ||
| -d '{"markdown" : "${{ github.server_url }}/${{ github.repository }} ${{ github.workflow }} failed"}' \ | ||
| "https://webexapis.com/v1/webhooks/incoming/${{ secrets.WEBEX_TOKEN }}" | ||
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
|
||
|
ejcsid marked this conversation as resolved.
Dismissed
|
||
Uh oh!
There was an error while loading. Please reload this page.