Skip to content

🐛 send Vary Origin for login-webcomponent CORS responses - #623

Open
ThomasAFink wants to merge 1 commit into
it-at-m:mainfrom
ThomasAFink:fix/login-webcomponent-cors-vary-origin
Open

🐛 send Vary Origin for login-webcomponent CORS responses#623
ThomasAFink wants to merge 1 commit into
it-at-m:mainfrom
ThomasAFink:fix/login-webcomponent-cors-vary-origin

Conversation

@ThomasAFink

@ThomasAFink ThomasAFink commented Jul 26, 2026

Copy link
Copy Markdown
Member

Changes

  • Add Vary: Origin next to the dynamic CORS header on /src/ and loader scripts so a cached response from one embedder host is not reused on another (button then fails to load). Example: load the button on zms-demo, then open zms-test in another tab — without this, the script is still cached with ACAO for demo and the button disappears on test.
  • Use always on the CORS headers
  • Also match root loader.js, not only loader-*.js

Reference

Issue: n/a

Checklist

General

  • Added meaningful PR title and list of changes in the description

Code

  • Wrote code and comments in English
  • Removed waste on branch (e.g. console.log), see code quality tooling

Dynamic Access-Control-Allow-Origin based on request Origin must not be
cached across different embedder hosts. Also cover root loader.js and
always emit CORS headers.
@ThomasAFink
ThomasAFink requested a review from a team as a code owner July 26, 2026 17:17
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 959984b2-d2f4-4741-af87-b0597622a7d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant