🐛 send Vary Origin for login-webcomponent CORS responses - #623
Open
ThomasAFink wants to merge 1 commit into
Open
🐛 send Vary Origin for login-webcomponent CORS responses#623ThomasAFink wants to merge 1 commit into
ThomasAFink wants to merge 1 commit into
Conversation
Dynamic Access-Control-Allow-Origin based on request Origin must not be cached across different embedder hosts. Also cover root loader.js and always emit CORS headers.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Vary: Originnext to the dynamic CORS header on/src/and loader scripts so a cached response from one embedder host is not reused on another (button then fails to load). Example: load the button onzms-demo, then openzms-testin another tab — without this, the script is still cached with ACAO for demo and the button disappears on test.alwayson the CORS headersloader.js, not onlyloader-*.jsReference
Issue: n/a
Checklist
General
Code
console.log), see code quality tooling