Fix flaky e2e tests in library reconciliation and gateway controller#2044
Closed
Copilot wants to merge 2 commits into
Closed
Fix flaky e2e tests in library reconciliation and gateway controller#2044Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
|
Collaborator
|
Hi @copilot. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Wrap ValidatingWebhookConfiguration drift mutation in Eventually to handle concurrent reconciler updates (conflict retries) - Narrow gateway controller readiness check to curl-client pod only, avoiding unrelated pods causing spurious failures Fixes #2038
Copilot
AI
changed the title
[WIP] Fix code as per review comment
Fix flaky e2e tests in library reconciliation and gateway controller
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Two e2e tests were producing intermittent failures due to race conditions and overly broad assertions.
library_reconcile_test.go— Wraps theValidatingWebhookConfigurationdrift mutation in anEventuallyblock. The background reconciler can update the webhook concurrently, causing a conflict error oncl.Update. Retrying resolves this without masking the actual drift-detection assertion that follows.gateway_controller_test.go— ReplacesCheckPodsReady(gatewayNamespace)(all pods) with a targeted readiness check on thecurl-clientpod by name. Gateway-provisioned pods that aren't part of the test scenario were causing spurious failures.Which issue(s) this PR fixes:
Related Issue/PR #2038
Additional information: