Conversation
lidel
requested changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Thank you for pushing this forward, quick feedback (can sync on Wednesday when i'm back):
- previews are provided by ipfs/ipfs-deploy-action -- it will create comment like this one
- in theory, we could limit how long our cluster keeps PR previews by setting
cluster-pin-expire-inon PR builds, but websites like helia.io are tiny so ok to pin forewer and figure out expiration in follow-up PR
- in theory, we could limit how long our cluster keeps PR previews by setting
⚠️ this needs to be refactored to avoid security issues, see two workflow model in: https://github.com/ipshipyard/ipfs-deploy-action?tab=readme-ov-file#dual-workflows-with-fork-prs- DNSLink update (if we are using Cloudflare token secret in CI) must be updated in Deploy workflow, and not the build one which could have thrid-party code
- TLDR: Build works without secrets, Deploy uses code from master, and not fork, and uses output from Build. If we follow this, the surface for abuse via fork PR is removed.
d32b9a3 to
559f651
Compare
- move branch check from step to job level to skip unnecessary job runs - add missing trailing newlines
lidel
approved these changes
Dec 4, 2025
Contributor
lidel
left a comment
There was a problem hiding this comment.
lgtm, I guess we merge and see how it behaves in main, and if any issues, fix in follow-up commit/pr
Contributor
|
https://github.com/ipshipyard/www-helia-io/actions/runs/19945830027/job/57194943496#step:2:59 looks fine, updated DNSLink to the new CID: I'll update CNAME to use ipshipyard.tech instead of Fleek. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the IPFS + DNSLink deployment.
Some questions for review:
cc @achingbrain @lidel