Skip to content

Update to the latest core#1345

Merged
ischasny merged 1 commit intomainfrom
ivan/update-to-the-latest-core
Mar 4, 2023
Merged

Update to the latest core#1345
ischasny merged 1 commit intomainfrom
ivan/update-to-the-latest-core

Conversation

@ischasny
Copy link
Copy Markdown
Contributor

@ischasny ischasny commented Mar 2, 2023

Update to the latest version of the core that fixes the bug with second hash calculation.

I'll update this branch to point to the release version once the linked PR is merged.

@ischasny ischasny requested a review from masih March 2, 2023 14:48
@masih
Copy link
Copy Markdown
Member

masih commented Mar 2, 2023

This will break all current dhstore lookups right?

@ischasny
Copy link
Copy Markdown
Contributor Author

ischasny commented Mar 2, 2023

This will break all current dhstore lookups right?

Unfortunately, on a positive note - we should be able to re-ingest all data much quicker (on the course of 1-2 weeks) this time.

@gammazero
Copy link
Copy Markdown
Collaborator

Run go mod tidy please.

@ischasny
Copy link
Copy Markdown
Contributor Author

ischasny commented Mar 3, 2023

Run go mod tidy please.

It seems to be tidy unless I'm missing something?

@ischasny ischasny force-pushed the ivan/update-to-the-latest-core branch from 2971d0c to 794b34b Compare March 4, 2023 10:22
@ischasny
Copy link
Copy Markdown
Contributor Author

ischasny commented Mar 4, 2023

ping @masih please approve

@ischasny ischasny requested a review from gammazero March 4, 2023 10:23
@ischasny ischasny force-pushed the ivan/update-to-the-latest-core branch from 794b34b to ab62e84 Compare March 4, 2023 10:29
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.81%. Comparing base (1d8256c) to head (ab62e84).
⚠️ Report is 1331 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   53.85%   55.81%   +1.95%     
==========================================
  Files         149      151       +2     
  Lines       15377    15828     +451     
==========================================
+ Hits         8281     8834     +553     
+ Misses       6155     6026     -129     
- Partials      941      968      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ischasny ischasny merged commit 45005f6 into main Mar 4, 2023
@ischasny ischasny deleted the ivan/update-to-the-latest-core branch March 4, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants