Open
Conversation
Verify that index-provider allows reusing the same context id. To do that one would need to call NotifyRemove followed by NotifyPut.
LexLuthr
approved these changes
Oct 23, 2023
LexLuthr
left a comment
LexLuthr
left a comment
There was a problem hiding this comment.
This looks good. Now, we need to figure out a way to implement this in Boost for specific deals or maybe a manual command would make more sense.
Contributor
Author
Sounds good - let's discuss at the Colo. |
ischasny
added
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that index-provider allows reusing the same context id. To do that one would need to call NotifyRemove followed by NotifyPut.
Do not merge yet as the correct logic here is still being determined. We might need to allow re-publishing advertisements for the same context id but with different multihashes without having to publish an explicit removal first.