Add Disclaimer to the Kubo integration doc#373
Conversation
|
CC @lidel |
lidel
left a comment
There was a problem hiding this comment.
sgtm, at least sets expectation YMMV 🙏
| "ListenMultiaddr": "/ip4/0.0.0.0/tcp/50617", | ||
| "ProviderID": "PEER ID OF YOUR IPFS NODE", | ||
| "Addrs": // List of multiaddresses that you'd like to be advertised to IPNI. If not specified, Swarm addresses of the Kubo node will be used. | ||
| "Addrs": [] // List of multiaddresses that you'd like to be advertised to IPNI |
There was a problem hiding this comment.
@jtsmedley would specifying Announce addrs here instead of Kubo solve the problem you had in ipfs/kubo#9823?
@ischasny should we add comment that this list, if not empty, overrides any Addrs sent by the client?
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 50.97% 51.13% +0.16%
==========================================
Files 61 61
Lines 4875 4875
==========================================
+ Hits 2485 2493 +8
+ Misses 2084 2077 -7
+ Partials 306 305 -1 ☔ View full report in Codecov by Sentry. |
See this for context