Skip to content

docs(examples): flaky test fix, avoid bitswap race, use ed25519#11282

Merged
lidel merged 1 commit intomasterfrom
examples/fix-flaky-ed25519
Apr 14, 2026
Merged

docs(examples): flaky test fix, avoid bitswap race, use ed25519#11282
lidel merged 1 commit intomasterfrom
examples/fix-flaky-ed25519

Conversation

@lidel
Copy link
Copy Markdown
Member

@lidel lidel commented Apr 13, 2026

Reduce example-test flakiness and align with current kubo conventions.

  • move peer connection before ipfsA.Unixfs().Add() so bitswap's peer-connected event settles before Part IV fetches; on a slow CI runner the 1s ProvSearchDelay can expire and fail the test
  • use Ed25519 keys via CreateIdentity, matching ipfs init default

TODO

  • re-run few times, confirm its no longer a flake

Reduce example-test flakiness and align with current kubo conventions.

- move peer connection before ipfsA.Unixfs().Add() so bitswap's
  peer-connected event settles before Part IV fetches; on a slow CI
  runner the 1s ProvSearchDelay can expire and fail the test
- use Ed25519 keys via CreateIdentity, matching `ipfs init` default
- comments are concise and avoid jargon
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Apr 13, 2026
@lidel lidel marked this pull request as ready for review April 13, 2026 22:27
@lidel lidel requested a review from a team as a code owner April 13, 2026 22:27
@gammazero gammazero changed the title docs(examples): avoid bitswap race, use ed25519 docs(examples): flaky test fix, avoid bitswap race, use ed25519 Apr 14, 2026
@lidel lidel merged commit f449e8b into master Apr 14, 2026
37 checks passed
@lidel lidel deleted the examples/fix-flaky-ed25519 branch April 14, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does NOT require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants