In templates, remove "lstrip('/')" from full node name#65
Open
Rezenders wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, the model generation removes the leading slash (the leftmost one), which is fine for nodes that don't contain any slashes in its name, but for nodes containing slashes, such as,
/mavros/mavros,/mavros/cmdetc the .ros2 DSL checkers complain.I get these 2 errors:
Adding a leading slash solves the problem. The issue is only with the .ros2 DSL but I also made the same change to the .rossystem DSL to make it consistent. Not sure if this should be fixed/changed in RosTooling itself or only in the generation.