Skip to content

ci: run macOS tests on Blacksmith; credit Blacksmith in docs - #9875

Merged
joshistoast merged 3 commits into
mainfrom
lstein/docs/add-blacksmith-logo-to-docs
Oct 17, 2026
Merged

joshistoast merged 3 commits into
mainfrom
lstein/docs/add-blacksmith-logo-to-docs

Conversation

@lstein

@lstein lstein commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves the macOS python tests to Blacksmith and credits Blacksmith as a sponsor.

  • CI: the python-tests matrix runs macOS on blacksmith-6vcpu-macos-15 (was macOS-14). Windows stays on GitHub's windows-2022 with its two-worker cap. Blacksmith's Windows runner is Windows Server 2025 Core, which lacks Media Foundation, the audio stack, and the Video-for-Windows DLLs (AVICAP32.dll, MSVFW32.dll) that every standard Windows ffmpeg build links, including imageio-ffmpeg's bundled binary. Media Foundation and sounddevice could be worked around in-job; ffmpeg could not, so ~170 video tests failed. The only source of those DLLs is the Server Core App Compatibility capability, which requires a reboot.
  • Docs: README and the docs landing page gain a Blacksmith sponsor section. The single logo copy lives at docs/src/content/docs/assets/blacksmith-logo.png; the README references it by absolute raw.githubusercontent URL so it also renders on PyPI.

Related Issues / Discussions

Follows #9802 and the linux python-tests move to Blacksmith.

QA Instructions

  • pnpm build, pnpm check-deploy-output, pnpm check-redirects, pnpm test in docs/: all pass; the landing page renders the Sponsors heading, sentence, and linked lazy-loaded logo.
  • py3.12: macos-default passes on the Blacksmith runner.
  • Windows findings come from CI runs on this branch: install logs, a DLL/feature probe on the runner, and PE import tables of the imageio-ffmpeg 0.6.0 and gyan.dev 7.1.1 Windows binaries.
  • The README logo 404s on this branch until merge, because its URL points at main.

Review

No material findings remain. Windows can move to Blacksmith once it offers a Desktop Experience image (or the App Compatibility capability is preinstalled).

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

🤖 Generated with Claude Code

@github-actions github-actions Bot added CI-CD Continuous integration / Continuous delivery Root python-tests PRs that change python tests docs PRs that change docs labels Oct 16, 2026
@lstein
lstein force-pushed the lstein/docs/add-blacksmith-logo-to-docs branch from 82550cd to ef04639 Compare October 16, 2026 01:14
@lstein lstein added the 7.0.0 label Oct 16, 2026
@joshistoast
joshistoast enabled auto-merge (squash) October 16, 2026 01:19
@lstein lstein moved this to 7.0 Theme: Modular Design in Invoke - Community Roadmap Oct 16, 2026
@lstein
lstein force-pushed the lstein/docs/add-blacksmith-logo-to-docs branch 3 times, most recently from b4e3f18 to c265da1 Compare October 16, 2026 02:16
lstein and others added 2 commits October 15, 2026 22:28
Moves the macOS job to blacksmith-6vcpu-macos-15. Windows stays on GitHub's windows-2022:
Blacksmith's Windows Server Core image lacks the Video-for-Windows DLLs ffmpeg links.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lstein
lstein force-pushed the lstein/docs/add-blacksmith-logo-to-docs branch from c265da1 to d8c1330 Compare October 16, 2026 02:28
@lstein lstein changed the title ci: run macOS and Windows tests on Blacksmith; credit Blacksmith in docs ci: run macOS tests on Blacksmith; credit Blacksmith in docs Oct 16, 2026
@joshistoast
joshistoast merged commit e448ef9 into main Oct 17, 2026
17 checks passed
@joshistoast
joshistoast deleted the lstein/docs/add-blacksmith-logo-to-docs branch October 17, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.0.0 CI-CD Continuous integration / Continuous delivery docs PRs that change docs python-tests PRs that change python tests Root

Projects

Status: 7.0 Theme: Modular Design

Development

Successfully merging this pull request may close these issues.

2 participants