docs(ios): - Improve Remote Notification Support section#1120
docs(ios): - Improve Remote Notification Support section#1120LunatiqueCoder wants to merge 5 commits intoinvertase:mainfrom
Conversation
LunatiqueCoder
changed the title
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
Lots of little nitpicks here and there but in general I really like this
Do you think you can incorporate these suggestions? A lot of them may be incorporated directly but some of them need to be manually added as they move things around just a little bit I think
Thank you!
|
|
||
| <br> | ||
|
|
||
| Before moving to the next step, run the app and check it builds successfully – make sure you have the correct target selected. |
There was a problem hiding this comment.
I also like this suggestion here again - so they do a build test once before they try to do custom code, and now they do another build test after trying to make custom code but before moving on
|
Niiice. I resolved those ones that I just mostly copy pasted from you. Feel free to unresolve or come with other comments/suggestions. :) |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
still working through new-arch problems sadly, but in this repo - I'm here, just everything taking time |
|
finally got the docs publishing here again, on the docs.page platform - just finished that today - one step closer on all this backlog here |
3 participants
Hello!
A little revamp on the docs, added what tricks helped me, also mentioned what issued I ran into, etc etc.
Here are some main changes:
You can see the new README here:
https://github.com/LunatiqueCoder/notifee/blob/patch-1/docs-react-native/react-native/docs/ios/remote-notification-support.md
Hope you'll like it
Cheers 🍻