You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Only round an AnchoredInterval when the keyword round is set. Display of AnchoredIntervals using Period spans will always show the interval as rounded currently
The issue that I have with this approach is that it allows the user to pass in a round=true kwarg that doesn't actually do something when P isn't a Period. I think a cleaner solution is to just create a pair of pseudoconstructors HE and HB that do the rounding. (I've done this in the branch that I'm working on now, but am still working a fix for the display of non-rounded AnchoredIntervals.)
Yep. The syntax would be slightly different (using the value for Period and the type for everything else). I no longer think it's worth implementing for the type itself, though, given that our only use case is for hour ending and we were talking about having a shorter pseudoconstructor anyway.
Ok, I expect I'll close this. I'll leave it open for now as things change around this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only round an
AnchoredIntervalwhen the keywordroundis set. Display ofAnchoredIntervals usingPeriodspans will always show the interval as rounded currently