Avoid risk of bad dirname when username is unusual#70
Merged
gjsjohnmurray merged 5 commits intointersystems-community:mainfrom Apr 21, 2026
Merged
Avoid risk of bad dirname when username is unusual#70gjsjohnmurray merged 5 commits intointersystems-community:mainfrom
gjsjohnmurray merged 5 commits intointersystems-community:mainfrom
Conversation
gjsjohnmurray
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #67. When a username doesn't match regex
/^[A-Za-z0-9.]*$/we now name its server-side folder using the base64 encoding of the username, prepended with@. As a convenience we also write the unencoded username into a file named _username.txt in the folder.