[_]: refactor(account): remove network_bucket_id from mail accounts

migrations/20260821201057-drop-network-bucket-id-from-mail-accounts.js

@@ -0,0 +1,19 @@
+'use strict';
+
+const TABLE_NAME = 'mail_accounts';
+const COLUMN_NAME = 'network_bucket_id';
+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface) {
+    await queryInterface.removeColumn(TABLE_NAME, COLUMN_NAME);
+  },
+
+  async down(queryInterface, Sequelize) {
+    await queryInterface.addColumn(TABLE_NAME, COLUMN_NAME, {
+      type: Sequelize.STRING(24),
+      allowNull: true,
+      defaultValue: null,
+    });
+  },
+};

src/modules/account/domain/mail-account.domain.ts

@@ -14,7 +14,6 @@ export interface MailAccountAttributes {
   userId: string;
   status: MailAccountState;
   suspendedAt: Date | null;
-  networkBucketId: string | null;
   addresses: MailAddressAttributes[];
   createdAt: Date;
   updatedAt: Date;
@@ -25,7 +24,6 @@ export class MailAccount {
   readonly userId!: string;
   readonly status!: MailAccountState;
   readonly suspendedAt!: Date | null;
-  readonly networkBucketId!: string | null;
   readonly addresses!: MailAddress[];
   readonly createdAt!: Date;
   readonly updatedAt!: Date;

src/modules/account/models/mail-account.model.ts

@@ -46,10 +46,6 @@ export class MailAccountModel extends Model {
   @Column(DataType.DATE)
   declare suspendedAt: Date | null;
 
-  @AllowNull(true)
-  @Column({ field: 'network_bucket_id', type: DataType.UUID })
-  declare networkBucketId: string | null;
-
   @Column(DataType.DATE)
   declare deletedAt: Date | null;
 

src/modules/account/repositories/account.repository.spec.ts

@@ -38,7 +38,6 @@ describe('AccountRepository', () => {
       userId: 'user-1',
       status: 'active',
       suspendedAt: null,
-      networkBucketId: null,
       createdAt: new Date('2026-01-01T00:00:00.000Z'),
       updatedAt: new Date('2026-01-02T00:00:00.000Z'),
       addresses: [],
@@ -135,17 +134,6 @@ describe('AccountRepository', () => {
     });
   });
 
-  describe('setNetworkBucketId', () => {
-    it('when given an id and bucket id, then updates the account row', async () => {
-      await repository.setNetworkBucketId('acc-1', 'bucket-1');
-
-      expect(accountModel.update).toHaveBeenCalledWith(
-        { networkBucketId: 'bucket-1' },
-        { where: { id: 'acc-1' } },
-      );
-    });
-  });
-
   describe('suspend', () => {
     it('when given an id, then sets status suspended and suspendedAt', async () => {
       await repository.suspend('acc-1');

src/modules/account/repositories/account.repository.ts

@@ -54,10 +54,6 @@ export class AccountRepository {
     await this.accountModel.destroy({ where: { id }, force: options?.force });
   }
 
-  async setNetworkBucketId(id: string, networkBucketId: string): Promise<void> {
-    await this.accountModel.update({ networkBucketId }, { where: { id } });
-  }
-
   async suspend(id: string): Promise<void> {
     await this.accountModel.update(
       { status: MailAccountState.Suspended, suspendedAt: new Date() },
@@ -149,7 +145,6 @@ export class AccountRepository {
       userId: model.userId,
       status: model.status as MailAccountState,
       suspendedAt: model.suspendedAt,
-      networkBucketId: model.networkBucketId,
       createdAt: model.createdAt as Date,
       updatedAt: model.updatedAt as Date,
       addresses: (model.addresses ?? []).map(toAddressAttributes),

test/fixtures.ts

@@ -277,7 +277,6 @@ export function newMailAccountAttributes(
     userId: randomUuid(),
     status: MailAccountState.Active,
     suspendedAt: null,
-    networkBucketId: null,
     addresses: [address],
     createdAt: new Date(),
     updatedAt: new Date(),