Adding initial Korean translation#12830
Open
systil3 wants to merge 2 commits into
Open
Conversation
Member
|
Thank you for contributing, @systil3! Welcome to Open Library — this appears to be your first contribution to the project. 🤖 Copilot has been assigned for an initial review. This PR has no linked issue, so it will go through triage before a reviewer is assigned. Triage runs on Mondays and Fridays. There are currently 66 open non-draft PRs in the queue ahead of yours. Possible improvements for this PR
PR triage checklist (maintainers / Pam)
Note This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds an initial Korean (ISO 639-1:
ko) translation for Open Library.Korean is spoken by approximately 80 million people worldwide, including large communities in South Korea, North America, etc. This PR creates
openlibrary/i18n/ko/messages.powith translations covering the whole UI element with EN including core features : account management, borrowing, book editing, navigation, and notifications. This also modifies get_supported_languages() ofopenlibrary/code.pyas adding one line to apply Korean mapping.This contribution aims to make Open Library more accessible to Korean-speaking users.
Technical
All msgid strings were translated to natural, commonly-used Korean.
Since Korean does not grammatically distinguish singular from plural in the same way English does, we set all plural msgstr entries to use index [0] only.
Technical terms or proper nouns without established Korean equivalents (e.g. "Internet Archive", "eBook", "ISBN", "reCAPTCHA", "Adobe Digital Editions") were kept in their original form exceptionally.
Testing
As indicated in the internationalization section of the open library docs, you can build the modifications using the line
docker compose run --rm -uroot home make i18nand validate them using the linedocker compose exec -uroot web ./scripts/i18n-messages validate ko.Screenshot
Stakeholders
@gladmanhh : helped modify line around 5800 ~ 8700 of messages.po
@hajicastle : helped line 2900~5800