WEBDEV-8509: Migrate iaux-item-metadata into elements#53
Open
jbuckner wants to merge 2 commits into
Open
Conversation
Moves @internetarchive/iaux-item-metadata models into src/models/item-metadata/. Field-parser imports rewritten to @src/parsers/* (the in-tree paths landed by WEBDEV-8507). Adds typescript-memoize as a runtime dependency. The addeddate test was using local-time setters to compare against a UTC-suffixed ISO timestamp; switched to setUTCHours/etc so the test isn't TZ-dependent under Vitest's browser provider. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
5 tasks
…rate-item-metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves @internetarchive/iaux-item-metadata into
src/models/item-metadata/per WEBDEV-8506 / #50. Item metadata models (File,Review,Metadata,SpeechMusicASREntry,Task) plus their field wrappers (BooleanField,ByteField,DurationField,ListField, etc.).WEBDEV-8507-migrate-field-parsers) because the field-parsers must be in tree before item-metadata canimport { BooleanParser } from '@src/parsers/...'. Base will auto-rebase tomainwhen #51 merges.Changes
src/models/item-metadata/— 5 top-level models (file,metadata,review,speech-music-asr-entry,task).src/models/item-metadata/metadata-fields/—MetadataFieldbase class plus 9 typed field wrappers (boolean,byte,date,duration,list,mediatype,number,page-progression,string).@internetarchive/field-parsersimport points at the in-tree@src/parsers/field-types/...path. Barrel imports of multiple parsers became one explicit import per parser (clearer + tree-shake-friendly).FieldParserInterfacenow imports from@src/parsers/field-parser-interface.package.json— addstypescript-memoizeas a runtime dependency (used by@Memoize()decorators onMetadataFieldaccessors).metadata.test.tsaddeddatetest was rewritten to usesetUTCHours/...so it matches theZ-suffixed ISO timestamp regardless of the runner's local timezone (the old test relied on the wtr runner being in UTC).Verification
npm run build✓npm run test✓ — 272 tests pass (61 new across item-metadata)npm run circular✓Order in the migration chain
metadata-service, which constructsMetadata/File/Reviewmodels).Test plan
file.tsandlist.ts(the two files that previously pulled multiple symbols from the barrel)typescript-memoizebelongs independencies(it's used at runtime by@Memoize()decorators), notdevDependencies🤖 Generated with Claude Code