WEBDEV-8508: Migrate result-type into elements#52
Open
jbuckner wants to merge 3 commits into
Open
Conversation
Moves @internetarchive/result-type into src/types/result.ts. Pure TypeScript type — no runtime artifact. Test ported to vitest; the FooErrorType enum used by the error test became a const object for erasableSyntaxOnly compatibility. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 78.75% 79.66% +0.90%
==========================================
Files 16 16
Lines 645 659 +14
Branches 168 177 +9
==========================================
+ Hits 508 525 +17
+ Misses 95 90 -5
- Partials 42 44 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add an interactive `result-story` built on the shared `story-template`, illustrating the two shapes of `Result<T, E>` (success/error) and the narrowing pattern a caller uses to consume one. Broaden the demo `app-root.ts` glob to `../src/**/*-story.ts` so stories outside `elements`/`labs` are auto-discovered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
@internetarchive/result-typeintosrc/types/result.tsper WEBDEV-8506 (#50) — smallest link in the chain: one pure-TSResult<T, E>interface thatmetadata-serviceuses to wrap success/error responses.result.ts— exact copy of the interface.result.test.ts— ported to Vitest; test-internalenum→const … as constforerasableSyntaxOnly.Blocked by #50; blocks WEBDEV-8510 (metadata-service). Build + 213 tests + circular green. QA-waived — types only.
WEBDEV-8508