WEBDEV-8508: Migrate result-type into elements#52
Open
jbuckner wants to merge 2 commits into
Open
Conversation
Moves @internetarchive/result-type into src/types/result.ts. Pure TypeScript type — no runtime artifact. Test ported to vitest; the FooErrorType enum used by the error test became a const object for erasableSyntaxOnly compatibility. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 16 16
Lines 645 645
Branches 168 168
=======================================
Hits 508 508
Misses 95 95
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves @internetarchive/result-type into
src/types/result.tsper WEBDEV-8506 / #50. The smallest of the migration chain — one pure-TypeScript interface thatmetadata-serviceuses to wrap success/error responses.Changes
src/types/result.ts— exact copy of theResult<T, E>interface.src/types/result.test.ts— ported to vitest. The error-initialization test used a runtimeenum FooErrorType, converted to aconst … as const+ type alias to satisfyerasableSyntaxOnly: true.Verification
npm run build✓npm run test✓ — 213 tests pass (2 new)npm run circular✓Order in the migration chain
metadata-service, which wraps responses inResult).QA waived — types-only, no runtime artifact.
Test plan
🤖 Generated with Claude Code