Skip to content

Switch "Copy Link to Highlight" to use custom highlight rendering + beginnings of annotations support #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdrini merged 23 commits into from
May 29, 2026

Fix "Copied" message shorter than actual button

02b848c
Select commit
Loading
Failed to load commit list.
Merged

Switch "Copy Link to Highlight" to use custom highlight rendering + beginnings of annotations support #1548

Fix "Copied" message shorter than actual button
02b848c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 29, 2026 in 0s

62.80% (-3.00%) compared to 452800b

View this Pull Request on Codecov

62.80% (-3.00%) compared to 452800b

Details

Codecov Report

❌ Patch coverage is 17.08543% with 330 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.80%. Comparing base (452800b) to head (02b848c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/util/TextSelectionManager.js 16.00% 308 Missing and 7 partials ⚠️
src/plugins/plugin.text_selection.js 23.07% 10 Missing ⚠️
src/BookReader.js 33.33% 2 Missing ⚠️
src/plugins/url/plugin.url.js 60.00% 2 Missing ⚠️
src/plugins/url/UrlPlugin.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   65.79%   62.80%   -3.00%     
==========================================
  Files          67       67              
  Lines        5853     6108     +255     
  Branches     1276     1333      +57     
==========================================
- Hits         3851     3836      -15     
- Misses       1968     2231     +263     
- Partials       34       41       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov