[XPU] Harden fused GDN recurrent state updates - #570
Open
gc-fu wants to merge 1 commit into
Open
Conversation
Validate tensor contracts and state indices, remove the cross-work-group inline shift race, encode the shift dependency explicitly, use bounds-safe scalar loads, and correct operator mutation schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conv_stateshift that can race across HV work-groupsCorrectness and performance tradeoff
The prior small-grid shortcut could update
conv_statewhile another work-group was still reading the old state. This PR always uses a second state-shift kernel to make ordering correct. Small workloads therefore gain one kernel submission; larger workloads already used a separate shift kernel. The dependency is explicit rather than relying on queue ordering.Scope
This is a kernel-only hardening stage following #569. The operator names and call signatures are unchanged, so no framework PR is required.
Testing
Not run as part of PR creation.