Fix #533: guard out_proj.weight access in GDN out-projection ESIMD probes - #557
Open
joaovgaraujo wants to merge 1 commit into
Open
Fix #533: guard out_proj.weight access in GDN out-projection ESIMD probes#557joaovgaraujo wants to merge 1 commit into
joaovgaraujo wants to merge 1 commit into
Conversation
…MD probes Quantized RowParallelLinear layers expose qweight, not weight. Both GDN out-projection eligibility probes read self.out_proj.weight unconditionally, so hybrid GPTQ/AWQ models crash with AttributeError on the first forward pass. getattr with a None default lets the existing short-circuit (ok = w is not None and ...) fall through to the generic out_proj path, which already handles GPTQ/AWQ correctly. Signed-off-by: Joao Vitor Guedes de Araujo <184870811+joaovgaraujo@users.noreply.github.com>
joaovgaraujo
force-pushed
the
fix/gdn-outproj-weight-getattr-533
branch
from
July 22, 2026 16:23
4a14064 to
2ac4ba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both GDN out-projection eligibility probes read
self.out_proj.weightunconditionally. QuantizedRowParallelLinearlayers expose.qweight, not.weight, so hybrid GDN+MoE models loaded with GPTQ/AWQ crash on the first forward pass withAttributeError: 'RowParallelLinear' object has no attribute 'weight'.Fix
w = getattr(self.out_proj, "weight", None)in both_gdn_outproj_esimd_eligibleand_gdn_outproj_batched_esimd_eligible(ingdn_linear_attn.py, applied throughvllm/patches/vllm_for_multi_arc.patch).The existing check
ok = (w is not None and ...)already short-circuits: whenwisNone,okbecomesFalseand execution falls through to the genericself.out_proj(core_attn_out)call, which already dispatches GPTQ/AWQ correctly throughint4_gemm_w4a16. For fp8 layers,getattrreturns the same tensor object as the direct attribute access, so that path is unchanged.Testing
Ran on an Intel Arc Pro B70 (32GB, Battlemage G21) with
intel/llm-scaler-vllm:0.21.0-b1.Before:
palmfuture/Qwen3.6-35B-A3B-GPTQ-Int4loads and starts the server, then crashes on the first inference request with the #533 AttributeError.After: the same model loads, serves, and generates correct output end to end at 15.9 tok/s (single-request decode, GPTQ path). Re-checked the sym_int4 and fp8 out-projection paths on the same card afterward; both still pass.
Closes #533.