Handle finite disjunct constraints in an InfiniteGDP model for MBM - #146
Open
dnguyen227 wants to merge 3 commits into
Open
dnguyen227 wants to merge 3 commits into
dnguyen227 wants to merge 3 commits into
Conversation
The extension routed every disjunct constraint of an InfiniteModel through the per-support M sampler, which only accepts an array of transcribed objectives. A disjunct constraint with no infinite variables transcribes to a single expression and raised "Unrecognized `sampler` value" for both the exhaustive and the GP sampler, whether the disjunction had other infinite constraints or not. raw_M now solves such a constraint's single M subproblem directly and skips the sampler.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 21 21
Lines 2265 2267 +2
=======================================
+ Hits 2258 2260 +2
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@pulsipher ready for review |
Collaborator
|
Please merge with main to get to resolve conflicts |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While sampling M values for InfGDP problems, the possibility of finite disjunction constraints was not considered. Small fix applied here.
Upon running you'd get
,