-
Notifications
You must be signed in to change notification settings - Fork 246
Display path of current source file in header bar #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qhuy4119
wants to merge
17
commits into
inducer:main
Choose a base branch
from
qhuy4119:display-source-file-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+281
−15
Open
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2490d0e
display full path of current source file in header bar
qhuy4119 f808ccc
Merge branch 'main' into display-source-file-name
qhuy4119 e4af74a
Display path to current source file dynamically based on terminal width
qhuy4119 2f83fa4
Merge branch 'inducer:main' into display-source-file-name
qhuy4119 9263afe
Merge branch 'display-source-file-name' of github.com:qhuy4119/pudb i…
qhuy4119 28b9a55
replace single quote with double quote
qhuy4119 1446480
`caption` should be a list, not string
qhuy4119 eb97760
fix bug when source filename is not available
qhuy4119 7035e96
Use `class Caption(urwid.Text)` to represent the header.
qhuy4119 f1aef6c
Redesign `class Caption(urwid.Text)` and fix bug
qhuy4119 afd74fe
Merge branch 'main' into display-source-file-name
qhuy4119 797bb30
Add more tests and fix formatting
qhuy4119 d909e2a
Merge remote-tracking branch 'origin/display-source-file-name' into d…
qhuy4119 418a4d9
Put terminal sizes generating code into 1 fixture
qhuy4119 9584a9f
Make sure the content passed to urwid is of type str
qhuy4119 47d2026
Replace list destructuring with CaptionParts._make()
qhuy4119 ca4c7f1
Remove redundant test and fix formatting
qhuy4119 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that! This isn't quite the right way to do this IMO. Instead, this should be done in the repaint method for a widget, where Urwid supplies the amount of space available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need more guidance because I'm not sure what you are referring to.
Are you talking about urwid.Text.render, or some repaint code in PuDB, or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm talking about subclassing
urwid.WidgetorTextand implementing our ownrendermethod.