Skip to content

integrate search project to backend #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naufalyukafi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

integrate search project to backend #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf704af
integrate search project to backend
naufalyukafi Aug 26, 2020
7bec61d
update projectfilter
naufalyukafi Aug 28, 2020
38e15e9
add debounce
naufalyukafi Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/modules/LoggedIn/Project/ProjectFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ const ProjectFilter = () => {
<Col>
<Search
placeholder="Search Project Name Card"
onChange={item =>
projectSyncContext.setSearchByName(item.target.value)
}

@mnindrazaka mnindrazaka Aug 27, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kyknya lebih baik kalau dibuatin event handler function di componentnya, misal handleSearchChange dan dibungkus dengan React.useCallback. Sehingga setiap kali rerender tidak akan membuat function baru seperti ini

style={{ width: 200 }}
/>
</Col>
Expand Down
10 changes: 8 additions & 2 deletions src/modules/LoggedIn/Project/ProjectSyncContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ type ProjectSyncValue = {
setSortBy: (sortBy: string) => void;
sortDirection: "asc" | "desc";
setSortDirection: (sortDirection: "asc" | "desc") => void;
searchByName: string;
setSearchByName: (searchByName: string) => void;

@mnindrazaka mnindrazaka Aug 27, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kalau nama state nya diganti dengan searchQuery gimana ? supaya kedepannya satu state ini bisa digunakan untuk berbagai macam pencarian. Gak cuma searchByName aja

@naufalyukafi naufalyukafi Aug 27, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owalah baik mas.

};

export const useProjectSync = (): ProjectSyncValue => {
const [sortBy, setSortBy] = React.useState<string>("createdAt");
const [sortDirection, setSortDirection] = React.useState<"asc" | "desc">(
"desc"
);
const [searchByName, setSearchByName] = React.useState<string>("");
const [page, setPage] = React.useState<number>(1);
const [hasNextPage, setHasNextPage] = React.useState<boolean>(false);

const {
data,
isValidating,
Expand All @@ -44,7 +46,7 @@ export const useProjectSync = (): ProjectSyncValue => {
errorMutate,
request,
} = useRequest<Project[]>(
`/project?page=1&itemPerPage=8&sortBy=${sortBy}&sortDirection=${sortDirection}`
`/project?page=1&itemPerPage=8&sortBy=${sortBy}&sortDirection=${sortDirection}&name=${searchByName}`
);

const projects = React.useMemo(() => {
Expand Down Expand Up @@ -171,6 +173,8 @@ export const useProjectSync = (): ProjectSyncValue => {
setSortBy,
sortDirection,
setSortDirection,
searchByName,
setSearchByName,
};
};

Expand All @@ -187,6 +191,8 @@ const ProjectContext = React.createContext<ProjectSyncValue>({
setSortBy: () => {},
sortDirection: "asc",
setSortDirection: () => {},
searchByName: "",
setSearchByName: () => {},
});

export const ProjectProvider = (props: { children: React.ReactNode }) => {
Expand Down