Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

Refactor Binding and Prefix to use Rc for pointers #57

Open
ahomescu wants to merge 80 commits into
base: master
Choose a base branch
from
Open

Refactor Binding and Prefix to use Rc for pointers #57

Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
8d1a2e1
Replace m_dtd type with Rc<RefCell<DTD>>
ahomescu Feb 20, 2020
cb96243
Simplify some code in xmlparse.rs
ahomescu Feb 21, 2020
9a5caeb
Move a let statement lower in the function
ahomescu Feb 21, 2020
f5f9bc0
Merge branch 'master' into feature/cow_dtd
ahomescu Feb 21, 2020
7c27067
Update lifetimes
ahomescu Feb 22, 2020
aa8cb89
Replace pointer to DTD in XML_ParserStruct with a Cow<DTD>
ahomescu Feb 22, 2020
f67515b
Convert dtd{Create,Reset,Copy} into methods of DTD
ahomescu Feb 24, 2020
8953fc4
Merge both lifetimes for DTD::try_clone into a single one
ahomescu Feb 24, 2020
02d35d4
Implement Default for prefix
ahomescu Feb 24, 2020
8246c5c
Implement panicking Clone for Scaffold
ahomescu Feb 24, 2020
844a66e
Rename Scaffold to DTDScaffold
ahomescu Feb 24, 2020
c750c17
Store the parent parser in XML_ParserStruct as an Option-of-reference…
ahomescu Feb 25, 2020
8fdf975
Simplify XML_ExternalEntityParserCreate
ahomescu Feb 25, 2020
998fe9b
Replace 'p lifetime with 'parser
ahomescu Feb 26, 2020
387f445
Implement our own fallible Rc<T> and use it instead of Cow
ahomescu Feb 27, 2020
548a22b
Add assertion that old_rc isn't the maximum value before increment
ahomescu Feb 27, 2020
77f43be
Replace m_parentParser reference with a boolean is_child_parser flag …
ahomescu Mar 5, 2020
44e3ddc
Merge branch 'master' into feature/cow_dtd
ahomescu Mar 24, 2020
52aff93
Un-implement Send and Sync for our Rc
ahomescu Mar 24, 2020
6d667a0
Refactor Binding and Prefix to use Option<Rc<T>> for pointers
ahomescu Mar 24, 2020
cb68bbd
Implement Drop for Binding
ahomescu Mar 25, 2020
3d5f2d5
Remove a redundant Cell set to None
ahomescu Mar 25, 2020
19082e2
Simplify the transmute code in Rc::try_new
ahomescu Mar 26, 2020
6507602
Add comment on tables/pools split in DTD
ahomescu Mar 27, 2020
7b6fe2b
Switched some pointer arguments to references
ahomescu Mar 27, 2020
31f5484
Add comment on the first field of DTDPools
ahomescu Mar 27, 2020
2b86627
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Mar 28, 2020
75cb5a4
Remove some explicit dereferences
ahomescu Mar 28, 2020
e52a233
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Mar 28, 2020
7fd28ab
Remove more explicit dereferences
ahomescu Mar 28, 2020
0593050
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Mar 28, 2020
0a52595
Mark a couple of refactored functions as safe
ahomescu Mar 28, 2020
46567b1
Use Rc for pointers to ElementType values
ahomescu Mar 28, 2020
f794197
Use Rc for pointers in and to AttributeId structures
ahomescu Mar 28, 2020
c03c9c0
Remove some explicit dereferences
ahomescu Mar 28, 2020
a718693
Refactor OpenInternalEntity pointers into Option<Box<OpenInternalEnti…
ahomescu Mar 30, 2020
96d8388
Refactor Entity pointers into Ptr<Entity>
ahomescu Mar 31, 2020
4c8698a
Reduce the lifetime of one m_dtd.tables.borrow_mut() to a shorter sco…
ahomescu Mar 31, 2020
fc81468
Refactor Binding::uri into a Vec<XML_Char>
ahomescu Apr 4, 2020
064b8f9
Fix difference between mozilla/non-mozilla code
ahomescu Apr 4, 2020
36b12a6
Simplify a couple of post-increment assignments
ahomescu Apr 4, 2020
5d0c481
Remove unnecessary mutable local
ahomescu Apr 4, 2020
436ed12
Release Rc's inside Tag when moving it to the free list
ahomescu Apr 4, 2020
d30f2f5
Merge branch 'master' into feature/cow_dtd
ahomescu Apr 29, 2020
4adeafa
Remove outdated FIXME comment
ahomescu Apr 29, 2020
f51d1c3
Remove unnecessary lifetime
ahomescu Apr 29, 2020
c6bc130
Remove one unnecessary level of nesting in entity lookup code
ahomescu Apr 29, 2020
f63d3de
Merge branch 'master' into feature/cow_dtd
ahomescu Apr 29, 2020
2a9369f
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Apr 30, 2020
93003df
Some small changes to getAttributeId()
ahomescu Apr 30, 2020
084eb99
Remove redundant casts in HashKey::from calls
ahomescu Apr 30, 2020
032d01e
Merge branch 'master' into feature/cow_dtd
ahomescu Apr 30, 2020
6673af6
Pass Rc<Prefix> to addBinding by reference
ahomescu Apr 30, 2020
86f134f
Simplify some control flow in setContext()
ahomescu Apr 30, 2020
d51e92a
Reorder two locals for consistency
ahomescu Apr 30, 2020
d348d5c
Remove unnecessary reference
ahomescu Apr 30, 2020
82ea3a4
Pass Rc arguments by reference to defineAttribute()
ahomescu Apr 30, 2020
e509c66
Replace Rc argument with reference to inner value in setElementTypePr…
ahomescu Apr 30, 2020
dd40dc3
Use as_deref() to access self.m_declEntity's inner entity directly
ahomescu Apr 30, 2020
a00ea91
Replace one call to unwrap() with if let Some(...)
ahomescu Apr 30, 2020
ceb3aba
Raise the number of allowed allocations to make the test_misc_alloc_c…
ahomescu Apr 30, 2020
a85fd18
Restore the reallocation count checks in context_realloc_test and tes…
ahomescu Apr 30, 2020
0849dc4
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Apr 30, 2020
d979d55
Remove derives on Binding left over from previous merge
ahomescu Apr 30, 2020
1014300
Remove a couple of calls to Rc::clone
ahomescu Apr 30, 2020
1cf7d12
Remove unnecessary re-borrows of self.m_encoding
ahomescu Apr 30, 2020
56c0ac1
Replace some as_ref() calls with as_deref()
ahomescu Apr 30, 2020
de0eebe
Remove DTDPools and the surrounding RefCell since most StringPool met…
ahomescu Apr 30, 2020
703f0c3
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Apr 30, 2020
cba0d53
Convert Rc::get_mut() to an associated function
ahomescu Apr 30, 2020
ea353fc
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Apr 30, 2020
cb0e7a8
Backport the simplified Rc implementation from the feature/rc_binding…
ahomescu Apr 30, 2020
f3abb4a
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu Apr 30, 2020
bee70a9
Add comment on DTD tables field
ahomescu May 1, 2020
bc61236
Merge branch 'feature/cow_dtd' into feature/rc_bindings
ahomescu May 1, 2020
ae1c4cc
Merge branch 'master' into feature/rc_bindings
ahomescu May 1, 2020
0c3cb34
Remove obsolete comment
ahomescu Jun 16, 2020
85cf424
Merge branch 'master' into feature/rc_bindings
ahomescu Jun 16, 2020
9ea3d85
Reverse arm order in HashInsertResult::into_mut for consistency
ahomescu Jun 16, 2020
d84e97f
Merge branch 'master' into feature/rc_bindings
ahomescu Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading