transpile: In name_reference, also check expression for side effects#1763
Open
Rua wants to merge 7 commits intoimmunant:masterfrom
Open
transpile: In name_reference, also check expression for side effects#1763Rua wants to merge 7 commits intoimmunant:masterfrom
name_reference, also check expression for side effects#1763Rua wants to merge 7 commits intoimmunant:masterfrom
Conversation
Rua
force-pushed
the
index-lvalue
branch
2 times, most recently
from
11cea86 to
16adad1
Compare
Rua
changed the title
is_simple_lvalue, also check index expr for side effectsname_reference, also check expression for side effects
Rua
force-pushed
the
index-lvalue
branch
6 times, most recently
from
3d132ba to
f39150f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strange that this simple oversight was not caught sooner, despite already being clearly visible in the snapshot tests...