Skip to content

add scf_service_get_pg(3SCF), scf_service_add_pg(3SCF) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgallagher wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add scf_service_get_pg(3SCF), scf_service_add_pg(3SCF) #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f4e6f6
add scf_service_get_pg()
jgallagher Apr 12, 2026
c6c350e
add scf_service_add_pg()
jgallagher Apr 14, 2026
4869670
fix pointer const/mut
jgallagher Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/native.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,18 @@ extern "C" {
name: *const c_char,
out: *mut scf_instance_t,
) -> c_int;
pub fn scf_service_get_pg(
service: *const scf_service_t,
name: *const c_char,
out: *mut scf_propertygroup_t,
) -> c_int;
pub fn scf_service_add_pg(
service: *mut scf_service_t,
Copy link
Copy Markdown
Member

@jclulow jclulow Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be *const?

Copy link
Copy Markdown
Author

@jgallagher jgallagher Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Nice catch - thanks. Fixed both in 4869670

name: *const c_char,
pgtype: *const c_char,
flags: u32,
out: *mut scf_propertygroup_t,
) -> c_int;

pub fn scf_iter_scope_services(
iter: *mut scf_iter_t,
Expand Down
16 changes: 16 additions & 0 deletions src/stubs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,22 @@ mod stubs {
) -> c_int {
unimplemented!()
}
pub unsafe fn scf_service_get_pg(
service: *const scf_service_t,
name: *const c_char,
out: *mut scf_propertygroup_t,
) -> c_int {
unimplemented!()
}
pub unsafe fn scf_service_add_pg(
service: *mut scf_service_t,
Copy link
Copy Markdown
Member

@jclulow jclulow Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be *const?

name: *const c_char,
pgtype: *const c_char,
flags: u32,
out: *mut scf_propertygroup_t,
) -> c_int {
unimplemented!()
}

pub unsafe fn scf_iter_scope_services(
iter: *mut scf_iter_t,
Expand Down