Skip to content

Title: viewer: add ANSI SGR color rendering #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilia-maslakov merged 7 commits into from
Apr 12, 2026
Merged

Title: viewer: add ANSI SGR color rendering #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c45cd9
mcviewer (ansi.c): add ANSI SGR escape sequence parser.
noctuum Mar 13, 2026
67dc010
mcviewer (ascii.c): wire ANSI parser into text rendering pipeline.
noctuum Mar 13, 2026
07111db
mcviewer (ansi.c): harden SGR parser per review feedback.
noctuum Mar 13, 2026
cadc734
fix: remove duplicate tests/src/viewer/Makefile in configure.ac
ilia-maslakov Apr 12, 2026
670887d
viewer: add CK_AnsiMode toggle (Shift+F9) to activate ANSI color rend…
ilia-maslakov Apr 12, 2026
eae61d3
ext.d: preserve procyon ANSI colors when viewing .class files
ilia-maslakov Apr 12, 2026
0b552f7
viewer: preserve ANSI state across newlines in text renderer
ilia-maslakov Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/keybind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ static name_keymap_t command_names[] = {
ADD_KEYMAP_NAME_DESC (HexMode, N_ ("Toggle hex mode")),
ADD_KEYMAP_NAME_DESC (MagicMode, N_ ("Toggle magic mode")),
ADD_KEYMAP_NAME_DESC (NroffMode, N_ ("Toggle nroff mode")),
ADD_KEYMAP_NAME_DESC (AnsiMode, N_ ("Toggle ANSI color mode")),
ADD_KEYMAP_NAME_DESC (BookmarkGoto, N_ ("Go to bookmark")),
ADD_KEYMAP_NAME_DESC (Ruler, N_ ("Toggle ruler")),
ADD_KEYMAP_NAME_DESC (SearchForward, N_ ("Search forward")),
Expand Down
1 change: 1 addition & 0 deletions lib/keybind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ enum
CK_WrapMode = 600L,
CK_MagicMode,
CK_NroffMode,
CK_AnsiMode,
CK_HexMode,
CK_HexEditMode,
CK_BookmarkGoto,
Expand Down
11 changes: 8 additions & 3 deletions misc/ext.d/misc.sh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,14 @@ do_view_action() {
@EXTFSHELPERSDIR@/torrent list "${MC_EXT_FILENAME}" 2>/dev/null
;;
javaclass)
procyon "${MC_EXT_FILENAME}" 2>/dev/null || \
jad -p "${MC_EXT_FILENAME}" 2>/dev/null || \
(file -b "${MC_EXT_FILENAME}"; javap -private "${MC_EXT_FILENAME}" 2>/dev/null)
if command -v procyon >/dev/null 2>&1; then
script -q /dev/null -c "procyon \"${MC_EXT_FILENAME}\" 2>/dev/null"
elif command -v jad >/dev/null 2>&1; then
jad -p "${MC_EXT_FILENAME}" 2>/dev/null
else
file -b "${MC_EXT_FILENAME}"
javap -private "${MC_EXT_FILENAME}" 2>/dev/null
fi
;;
*)
;;
Expand Down
1 change: 1 addition & 0 deletions misc/mc.default.keymap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ SearchBackwardContinue = ctrl-r
SearchOppositeContinue = shift-n
MagicMode = f8
NroffMode = f9
AnsiMode = shift-f9
Home = ctrl-a
End = ctrl-e
Left = h; left
Expand Down
1 change: 1 addition & 0 deletions misc/mc.emacs.keymap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ SearchBackwardContinue = ctrl-r
SearchOppositeContinue = shift-n
MagicMode = f8
NroffMode = f9
AnsiMode = shift-f9
Home = ctrl-a
End = ctrl-e
Left = h; left
Expand Down
1 change: 1 addition & 0 deletions misc/mc.vim.keymap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ SearchBackwardContinue = ctrl-r
SearchOppositeContinue = shift-n
MagicMode = f8
NroffMode = f9
AnsiMode = shift-f9
Home = ctrl-a
End = ctrl-e
Left = h; left
Expand Down
1 change: 1 addition & 0 deletions src/viewer/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ noinst_LTLIBRARIES = libmcviewer.la

libmcviewer_la_SOURCES = \
actions_cmd.c \
ansi.c ansi.h \
ascii.c \
coord_cache.c \
datasource.c \
Expand Down
3 changes: 3 additions & 0 deletions src/viewer/actions_cmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,9 @@ mcview_execute_cmd (WView *view, long command)
case CK_NroffMode:
mcview_toggle_nroff_mode (view);
break;
case CK_AnsiMode:
mcview_toggle_ansi_mode (view);
break;
case CK_Home:
mcview_moveto_bol (view);
break;
Expand Down
Loading
Loading