Refactor Phase 2: Migrate UI scripts #525

[ikostan]

Move all user interface scripts into their respective subfolders within res://scripts/ui/.

---

name: Default Pull Request Template
about: Suggesting changes to SkyLockAssault
title: ''
labels: ''
assignees: ''

Description

What does this PR do? (e.g., "Fixes player jump physics in level 2" or "Adds
new enemy AI script")

Related Issue

Closes #ISSUE_NUMBER (if applicable)

Changes

• List key changes here (e.g., "Updated Jump.gd to use Godot 4.4's new Tween
  system")
• Any breaking changes? (e.g., "Deprecated old signal; migrate to new one")

Testing

• Ran the game in Godot v4.5 editor—describe what you tested (e.g., "Jump
  works on Win10 with 60 FPS")
• Any new unit tests added? (Link to test scene if yes)
• Screenshots/GIFs if UI-related: (Attach below)

Checklist

• Code follows Godot style guide (e.g., snake_case for variables)
• No console errors in editor/output
• Ready for review!

Additional Notes

Anything else? (e.g., "Tested on Win10 64-bit; needs Linux validation")

Summary by Sourcery

Enhancements:

• Align all UI-related scenes with the new scripts/ui subfolder structure by updating their attached script references.

Summary by CodeRabbit

• Chores
  • Reorganized internal code structure across multiple scenes to align with updated project architecture, with no changes to user-facing functionality or behavior.

[sourcery-ai]

🧙 Sourcery has finished reviewing your pull request!

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request reorganizes Godot scene file script resource paths. Multiple .tscn files were updated to reference scripts relocated from flat res://scripts/ directories to organized subdirectories under res://scripts/ui/, including menus/, components/, and screens/ folders.

Changes

Cohort / File(s)	Summary
Menu Scenes scenes/advanced_settings.tscn, scenes/audio_settings.tscn, scenes/gameplay_settings.tscn, scenes/main_menu.tscn, scenes/options_menu.tscn, scenes/pause_menu.tscn	Updated script ext_resource paths from res://scripts/ to res://scripts/ui/menus/ for all menu-related scene nodes.
Screen Scenes scenes/loading_screen.tscn, scenes/splash_screen.tscn	Updated script ext_resource paths from res://scripts/ to res://scripts/ui/screens/ for screen scene root nodes.
Key Mapping Menu scenes/key_mapping_menu.tscn	Updated script paths: root node from res://scripts/key_mapping.gd to res://scripts/ui/menus/key_mapping.gd and button components from res://scripts/input_remap_button.gd to res://scripts/ui/components/input_remap_button.gd.
Volume Control Scenes scenes/volume_controls/master_volume_control.tscn, scenes/volume_controls/music_volume_control.tscn, scenes/volume_controls/sfx_menu_volume_control.tscn, scenes/volume_controls/sfx_rotors_volume_control.tscn, scenes/volume_controls/sfx_volume_control.tscn, scenes/volume_controls/sfx_weapon_volume_control.tscn	Updated HSlider node script paths from res://scripts/volume_slider.gd to res://scripts/ui/components/volume_slider.gd.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related issues

• [FEATURE] Refactor Phase 2: Migrate UI scripts #525: Directly implements the UI scripts migration by updating scene ext_resource paths to reference relocated scripts organized under res://scripts/ui/ subdirectories.

Possibly related PRs

• Implement a custom splash screen #458: Related at the scene/script level—both involve the splash screen scene and its corresponding relocated script.
• Enable keyboard & dpad navigation for advanced settings #401: Related through shared script relocations—the main PR updates multiple scene files to reference scripts that were previously modified in this PR.
• Enable Keyboard & D-Pad Navigation for Main menu #390: Related—the main PR updates scene script paths to point to relocated scripts (e.g., main menu) that were modified in the retrieved PR.

Suggested labels

GUI

Poem

🐰 Scripts once scattered, now neatly organized,
From flat paths to folders, structure finalized,
UI menus, components, screens all arranged,
Scene references updated, connections unchanged,
Order restored in the quest's grand design!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is incomplete and largely relies on template boilerplate with checkboxes marked but no actual details provided.	Fill in the Description section with specific details about the script relocation, clarify what 'respective subfolders' means, provide actual testing details, and explain any potential breaking changes or migration steps needed.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: migrating UI scripts to organized subfolders within the res://scripts/ui/ directory structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor-phase-2-migrate-ui-scripts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepsource-io]

DeepSource Code Review

We reviewed changes in abfe2b3...6eb52a7 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
Python		Apr 21, 2026 3:47a.m.	Review ↗
JavaScript		Apr 21, 2026 3:47a.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

[ikostan]

@sourcery-ai guide