-
-
Notifications
You must be signed in to change notification settings - Fork 1
Implement a dedicated slider.wav sound effect that triggers only during manual slider adjustments #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Implement a dedicated slider.wav sound effect that triggers only during manual slider adjustments #578
Changes from 4 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
e2b619c
Merge pull request #573 from ikostan/main
ikostan 6e01bc9
Create slider.wav
espanakosta-jpg 9d4036a
Create slider.wav.import
espanakosta-jpg cacff88
Merge pull request #577 from ikostan/main
ikostan 0a50250
Merge pull request #586 from ikostan/main
ikostan 6f83b6f
[DOCUMENTATION] Milestone #16 README.md update #456
ikostan 84b3cff
Update README.md
ikostan 5ddea6d
https://github.com/ikostan/SkyLockAssault/issues/565
ikostan 77c27ad
[FEATURE] Connect VolumeSlider to Contextual Audio Feedback #566
ikostan c415e22
Update globals.gd
ikostan 461b09d
Update volume_slider.gd
ikostan d747662
Update .all-contributorsrc
ikostan d668e65
suggestion (bug_risk): Programmatic updates while the slider has focu…
ikostan 41a65f5
Update README.md
ikostan 95acc70
Update .all-contributorsrc
ikostan 4e2fda8
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
ikostan 3f5112f
Update volume_slider.gd
ikostan ba62539
Update volume_slider.gd
ikostan 0741179
audio_constants.gd singleton specifically built for preventing typos …
ikostan 2e5bca6
Update volume_slider.gd
ikostan 63e6a2a
Update README.md
ikostan 28d30a3
Update scripts/managers/audio_manager.gd
ikostan 4d17a2f
Update audio_manager.gd
ikostan 9261c1a
[FEATURE] Verify Signal Decoupling for Web and UI Sync #567
ikostan b71e4a9
New GUT unit tests
ikostan 11f4eba
Update volume_slider.gd
ikostan dc1ebea
Update volume_slider.gd
ikostan ec7ecb0
Update audio_manager.gd
ikostan 14a6f1d
Update audio_manager.gd
ikostan 1caf738
New GUT tests
ikostan 4eb74e0
Update test_volume_slider.gd
ikostan 2c92711
issue (bug_risk): Guard against invalid audio bus names to avoid runt…
ikostan fc74ecc
Update scripts/ui/components/volume_slider.gd
ikostan 0b6700a
Update scripts/ui/components/volume_slider.gd
ikostan 951c849
Test updates
ikostan 07d4012
Update scripts/ui/components/volume_slider.gd
ikostan df74365
Drag state may get stuck if release event is missed.
ikostan 47596d6
suggestion (performance): Avoid repeated warnings and load attempts f…
ikostan 71997b5
Use one English variant consistently (centralised vs centralized).
ikostan b1872eb
Restore AudioManager state after each test to prevent cross-suite lea…
ikostan 566f5bc
Rate-limit test can be flaky under load.
ikostan 2db4d9b
Test mutates live AudioManager / audio server state without isolation.
ikostan a760da5
test_sfx_guard_allows_valid_interaction will trigger real audio playb…
ikostan 9b50fbb
Duplicate section header.
ikostan b8c448f
Connect finished before calling play() for robustness.
ikostan e14872c
Update audio_manager.gd
ikostan a001b09
Update audio_manager.gd
ikostan becbbbb
Encapsulating VolumeSlider
ikostan 7c3afcd
Update volume_slider.gd
ikostan d545aa1
Guard ordering: _previous_value is committed before interaction/rate …
ikostan ddf4015
Debounce timer restarts even when the new value is effectively identi…
ikostan c179b1d
Update test_volume_slider.gd
ikostan 12c21c3
Update volume_slider.gd
ikostan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| [remap] | ||
|
|
||
| importer="wav" | ||
| type="AudioStreamWAV" | ||
| uid="uid://6asmf6p6ftp5" | ||
| path="res://.godot/imported/slider.wav-562467666e90bfee2364ab6985972073.sample" | ||
|
|
||
| [deps] | ||
|
|
||
| source_file="res://files/sounds/sfx/slider.wav" | ||
| dest_files=["res://.godot/imported/slider.wav-562467666e90bfee2364ab6985972073.sample"] | ||
|
|
||
| [params] | ||
|
|
||
| force/8_bit=false | ||
| force/mono=false | ||
| force/max_rate=false | ||
| force/max_rate_hz=44100 | ||
| edit/trim=false | ||
| edit/normalize=false | ||
| edit/loop_mode=0 | ||
| edit/loop_begin=0 | ||
| edit/loop_end=-1 | ||
| compress/mode=2 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.