Fix main scene orphan leaks and tune parallax decor with tests

scripts/main_scene.gd

@@ -13,8 +13,7 @@ var _showing_unbound_warning: bool = false
 var _showing_unbound_key_message: bool = false
 
 @onready var player: Node2D = $Player
-# @onready var stats_panel: Panel = $PlayerStatsPanel
-@onready var stats_panel: Variant = $PlayerStatsPanel
+@onready var stats_panel: Panel = $PlayerStatsPanel
 @onready var background: ParallaxBackground = $Background
 @onready var bushes_layer: ParallaxLayer = $Background/Bushes  # Reference to the bushes layer
 @onready var decor_layer: ParallaxLayer = $Background/Decor  # Reference to the decor layer
@@ -125,13 +124,17 @@ func setup_bushes_layer(viewport: Vector2) -> void:
 	var bush_ids: Array = Array(texture_preloader.get_resource_list()).filter(
 		func(id: String) -> bool: return id.begins_with("bush_")
 	)
-	print("Loaded ", bush_ids.size(), " bush textures")
 
 	if bush_ids.is_empty():
 		return
 
-	var num_bushes: int = bush_ids.size()
-	var layer_height: float = viewport.y * 4
+	# THE GOLDILOCKS ZONE:
+	# 8 screens is the sweet spot for infinite illusion vs CPU overhead
+	var screens_tall: float = 8.0
+	var layer_height: float = viewport.y * screens_tall
+
+	# Drop density multiplier to match
+	var num_bushes: int = bush_ids.size() * 2
 
 	for i in range(num_bushes):
 		var bush: Sprite2D = Sprite2D.new()
@@ -152,14 +155,14 @@ func setup_bushes_layer(viewport: Vector2) -> void:
 	bushes_layer.motion_mirroring = Vector2(0, layer_height)
 
 
-## Sets up the decor layer with random X positions, sizes, and textures.
+## Sets up the decor layer with random X positions, sizes, textures, rotations, and flips.
 ## @param viewport: Vector2 - The viewport size.
 ## @return: void
 func setup_decor_layer(viewport: Vector2) -> void:
 	if not decor_layer:
 		return
 
-	# Clear existing children
+	# Clear existing children (Instantly detach, then safely queue)
 	for child in decor_layer.get_children():
 		decor_layer.remove_child(child)
 		child.queue_free()
@@ -168,13 +171,20 @@ func setup_decor_layer(viewport: Vector2) -> void:
 	var decor_ids: Array = Array(texture_preloader.get_resource_list()).filter(
 		func(id: String) -> bool: return id.begins_with("decor_")
 	)
-	print("Loaded ", decor_ids.size(), " decor textures")
 
 	if decor_ids.is_empty():
 		return
 
-	var num_decors: int = decor_ids.size()
-	var layer_height: float = viewport.y * 4
+	# THE GOLDILOCKS ZONE:
+	# Match the bushes layer height
+	var screens_tall: float = 8.0
+	var layer_height: float = viewport.y * screens_tall
+
+	# Drop density multiplier to match
+	var num_decors: int = decor_ids.size() * 2
+
+	# Define strict rotation angles (0, 90, 180, -90 degrees)
+	var allowed_rotations: Array[float] = [0.0, 90.0, 180.0, -90.0]
 
 	for i in range(num_decors):
 		var decor: Sprite2D = Sprite2D.new()
@@ -183,9 +193,18 @@ func setup_decor_layer(viewport: Vector2) -> void:
 		decor.texture = texture_preloader.get_resource(id)
 		decor.centered = false
 
-		var scale_factor: float = randf_range(0.5, 1.0)
+		# SCALING TRICK 1: Wider scale range (0.5 to 1.5) for more size variance
+		var scale_factor: float = randf_range(0.5, 1.5)
 		decor.scale = Vector2(scale_factor, scale_factor)
 
+		# SCALING TRICK 2: Randomly mirror the sprite horizontally and/or vertically
+		decor.flip_h = [true, false].pick_random()
+		decor.flip_v = [true, false].pick_random()
+
+		# Apply random cardinal rotation to ALL decor sprites
+		var random_degrees: float = allowed_rotations.pick_random()
+		decor.rotation = deg_to_rad(random_degrees)
+
 		decor.position.x = randf_range(0, viewport.x - (decor.texture.get_width() * scale_factor))
 		decor.position.y = randf_range(
 			0, layer_height - (decor.texture.get_height() * scale_factor)
@@ -248,10 +267,6 @@ func show_message(text: String, type: MessageType = MessageType.CRITICAL_UNBOUND
 	match type:
 		MessageType.KEY_PRESS_UNBOUND:
 			_showing_unbound_key_message = false
-		# CRITICAL_UNBOUND: Do NOT reset here (once-per-session intent)
-		# Reset only when bindings are fixed
-		# (e.g., in key_mapping.gd _on_conflict_confirmed or reset)
-		# _showing_unbound_warning = false  # ← commented out
 
 
 ## Public: Clears the unbound warning flag after fixes.

test/gut/test_decor_layer_transformations.gd

@@ -0,0 +1,119 @@
+## Copyright (C) 2026 Egor Kostan
+## SPDX-License-Identifier: GPL-3.0-or-later
+## test_decor_layer_transformations.gd
+##
+## GUT unit tests for verifying randomized rotations, scaling,
+## and flipping applied to the main scene's decor layer.
+
+extends "res://addons/gut/test.gd"
+
+var main_scene: MainScene
+var viewport_mock: Vector2 = Vector2(1920, 1080)
+
+
+## Per-test setup: Isolate state and initialize scene.
+## :rtype: void
+func before_each() -> void:
+	await get_tree().process_frame
+	main_scene = preload("res://scenes/main_scene.tscn").instantiate()
+	add_child_autofree(main_scene)
+	await get_tree().process_frame
+
+
+## Per-test teardown: Aggressive memory cleanup.
+## :rtype: void
+func after_each() -> void:
+	if is_instance_valid(main_scene):
+		main_scene.free()
+	await get_tree().process_frame
+
+
+## test_decor_sprites_have_valid_cardinal_rotations |
+## Verifies every decor sprite is snapped to exactly 0, 90, 180, or -90 degrees.
+## :rtype: void
+func test_decor_sprites_have_valid_cardinal_rotations() -> void:
+	gut.p("Testing: All decor sprites must use strict cardinal rotations.")
+
+	main_scene.setup_decor_layer(viewport_mock)
+
+	var active_sprites: Array[Node] = main_scene.decor_layer.get_children().filter(
+		func(c: Node) -> bool: return not c.is_queued_for_deletion()
+	)
+
+	var allowed_radians: Array[float] = [
+		0.0, 
+		deg_to_rad(90.0), 
+		deg_to_rad(180.0), 
+		deg_to_rad(-90.0)
+	]
+
+	var invalid_rotations: Array[float] = []
+
+	for node in active_sprites:
+		var sprite := node as Sprite2D
+		var is_valid := false
+
+		# Check if the sprite's rotation matches any allowed radian (using approx to handle float drift)
+		for allowed_rad in allowed_radians:
+			if is_equal_approx(sprite.rotation, allowed_rad):
+				is_valid = true
+				break
+
+		if not is_valid:
+			invalid_rotations.append(sprite.rotation)
+
+	assert_eq(invalid_rotations.size(), 0, "Found decor sprites with non-cardinal rotations.")
+
+
+## test_decor_sprites_have_valid_scale_ranges |
+## Verifies every decor sprite scale falls between 0.5 and 1.5, and is uniformly scaled.
+## :rtype: void
+func test_decor_sprites_have_valid_scale_ranges() -> void:
+	gut.p("Testing: All decor sprites must be uniformly scaled between 0.5 and 1.5.")
+
+	main_scene.setup_decor_layer(viewport_mock)
+
+	var active_sprites: Array[Node] = main_scene.decor_layer.get_children().filter(
+		func(c: Node) -> bool: return not c.is_queued_for_deletion()
+	)
+
+	var out_of_bounds_scales: Array[Vector2] = []
+	var non_uniform_scales: Array[Vector2] = []
+
+	for node in active_sprites:
+		var sprite := node as Sprite2D
+		var s: Vector2 = sprite.scale
+
+		# Check bounds (using 0.49 and 1.51 to safely absorb floating point precision errors)
+		if s.x < 0.49 or s.x > 1.51:
+			out_of_bounds_scales.append(s)
+
+		# Check uniformity (x scale must equal y scale)
+		if not is_equal_approx(s.x, s.y):
+			non_uniform_scales.append(s)
+
+	assert_eq(out_of_bounds_scales.size(), 0, "Found decor sprites outside the 0.5 - 1.5 scale range.")
+	assert_eq(non_uniform_scales.size(), 0, "Found decor sprites with non-uniform (squished/stretched) scaling.")
+
+
+## test_decor_sprites_have_boolean_flips |
+## Verifies that flip_h and flip_v properties are actively being assigned.
+## :rtype: void
+func test_decor_sprites_have_boolean_flips() -> void:
+	gut.p("Testing: Decor sprites should successfully assign horizontal and vertical flips.")
+
+	main_scene.setup_decor_layer(viewport_mock)
+
+	var active_sprites: Array[Node] = main_scene.decor_layer.get_children().filter(
+		func(c: Node) -> bool: return not c.is_queued_for_deletion()
+	)
+
+	var null_flips_found: int = 0
+
+	for node in active_sprites:
+		var sprite := node as Sprite2D
+		# Verify the properties are valid booleans and not null/undefined
+		if typeof(sprite.flip_h) != TYPE_BOOL or typeof(sprite.flip_v) != TYPE_BOOL:
+			null_flips_found += 1
+
+	assert_eq(null_flips_found, 0, "All decor sprites must have valid boolean flip states.")

test/gut/test_decor_layer_transformations.gd.uid

@@ -0,0 +1 @@
+uid://dn1cexpx24og0