-
-
Notifications
You must be signed in to change notification settings - Fork 1
Emit speed_changed signal; add tests #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
cc33c56
Emit speed_changed signal; add tests
ikostan bd9f03c
Update player.gd
ikostan 1590492
Test name and assertions are inconsistent (max_and_min but only max i…
ikostan d857fe3
Update player.gd
ikostan e0715d7
Update player.gd
ikostan aa9fdc8
Update test_player_movement_signals.gd
ikostan a861547
Add HUD, wire it up & refactor player/settings
ikostan f7d0a6c
Update game_settings_resource.gd
ikostan 56a18a8
Update main_scene.gd
ikostan 3237fd1
Refactor tests to use Globals settings & HUD
ikostan ce6864d
Update tests for Globals/HUD refactor
ikostan 7b8127c
Update test_helpers.gd
ikostan 5459961
Update player.gd
ikostan 625942a
Update test_player_movement_signals.gd
ikostan e765c1f
Extract GUT mock builder to helper
ikostan bdd2377
Update scripts/game_settings_resource.gd
ikostan 9944fd7
Update game_settings_resource.gd
ikostan 4553ccd
Update game_settings_resource.gd
ikostan a358b22
Update scripts/hud.gd
ikostan 4d2c69d
Use GameSettingsResource for the speed thresholds instead of duplicat…
ikostan c957693
Update hud.gd
ikostan afdb474
Fix HUD logging and connection guards; add tests
ikostan 2122a7a
Update globals.gd
ikostan 6195b8c
Update hud.gd
ikostan 7557229
Update test_player.gd
ikostan 5d8f016
Update scripts/game_settings_resource.gd
ikostan 4e289dc
Update game_settings_resource.gd
ikostan 0746137
Update hud.gd
ikostan 6cc9a94
issue (bug_risk): high_yellow_fraction and low_yellow_fraction can be…
ikostan 3ee148e
issue (bug_risk): setup_hud assumes the player_node has a speed_chang…
ikostan 910d718
Release simulated actions before erasing them.
ikostan 6d0f630
This flameout assertion is currently ambiguous.
ikostan efecc65
suggestion (bug_risk): HUD does not react to speed-related setting ch…
ikostan c69e1fc
Expose HUD accessors and update tests
ikostan d6f09f5
Update hud.gd
ikostan 27dff10
Update hud.gd
ikostan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.