Adopt observer-based settings with automatic save and UI sync#469

Merged

ikostan merged 29 commits intomainfrom

migrate-to-resource-persistence

Mar 16, 2026

Commits on Mar 13, 2026

Commits on Mar 14, 2026

The enable_debug_logging setter has the same self-recursive assignment problem as current_log_level.
ikostan
committed
Bug: Label displays unclamped value when input exceeds bounds.
ikostan
committed
Test does not verify the intended observer behavior.
ikostan
committed

Commits on Mar 16, 2026

Update difficulty_flow_test.py
ikostan
committed
suggestion (bug_risk): UI updates for difficulty are now split between the external observer and the local value-changed handler, which is redundant and risks subtle signal loops.
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
suggestion: Log messages for log-level changes are now duplicated: once here and once via the centralized Observer.
ikostan
committed
Update advanced_settings.gd
ikostan
committed
suggestion: The write-back to Globals.settings.difficulty in the external observer looks unnecessary and slightly convoluted.
ikostan
committed
Update gameplay_settings.gd
ikostan
committed
Update scripts/game_settings_resource.gd

ikostan
and
coderabbitai[bot]
authored
Update scripts/gameplay_settings.gd

ikostan
and
coderabbitai[bot]
authored
Update game_settings_resource.gd
ikostan
committed
enable_debug_logging still does not persist across reloads.
ikostan
committed
Update scripts/game_settings_resource.gd

ikostan
and
sourcery-ai[bot]
authored
suggestion (performance): Observer handler may cause excessive disk writes and logging during bulk loads
ikostan
committed
Merge branch 'migrate-to-resource-persistence' of https://github.com/ikostan/SkyLockAssault into migrate-to-resource-persistence
ikostan
committed
Update difficulty_flow_test.py
ikostan
committed
Update difficulty_flow_test.py
ikostan
committed
style: format code with Black and isort
deepsource-autofix[bot]
authored