Custom cover art alt text#1387
Open
alice-blue wants to merge 18 commits into
Open
Conversation
…test this--the dev environment takes me to the live site instead of the dev version of this page.)
…lt text and printed below it for sighted users.
…game page. On the large image page, don't hide the image description behind details tags.
…e logged in and the game doesn't have one)
…ght/upload text and make it clear that the description was not necessarily authored by the artist or the person who uploaded it
…t text on the viewgame page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion elsewhere, this PR does the following:
Add a new column to the games table to store custom cover art descriptions.
Add a new field to the edit game form to add a cover art description.
Add a new help window, linked from the edit game form, with guidelines for cover art descriptions.
Add $alt_text parameter to coverArtThumbnail function so that alt text can be included in cover art thumbnails.
On the viewgame page, add alt text to the small cover, saying: "Cover art for [Game Title]. [Custom description, if there is one.] Click for full-sized image and copyright information."
On the full-sized cover art (visible when you click the small cover art on the viewgame page), add alt text saying the custom description if there is one. If there isn't a custom description, say "Cover art for [Game Title]" instead. Note: I have not been able to directly test any changes on this page, because the dev environment seems to redirect me to the live IFDB site instead.
Also on the full-sized cover art page, display the custom description as part of the main text (visible to everyone, not only screen reader users) in a box under the copyright information, and say that these descriptions are contributed by IFDB members (to try to make it clearer that descriptions are not necessarily written by whoever made the art or uploaded it). If there is no custom description, show a link to add one.
On the viewgame page, if there is no custom description and if the user is logged in, print a small link under the small cover art saying "add an image description." The link goes to the edit game form.
Fixes #1378. Related to #738.