Skip to content

coverart: Use latest version if requested version is greater #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salty-horse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

coverart: Use latest version if requested version is greater #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions www/coverart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,17 @@ if ($targVsn) {
if (isset($deltas['title']))
$title = $deltas['title'];

$pagevsn = (int)$rec['pagevsn'];

// Hack to assist local development, which uses production as an image source.
// If the target version is above what the server knows about, return the latest version.
if ($i == 0 && $pagevsn < $targVsn) {
$foundvsn = true;
break;
}

// stop if this is the version we're looking for
if ((int)$rec['pagevsn'] == $targVsn)
if ($pagevsn == $targVsn)
{
$foundvsn = true;
break;
Expand All @@ -133,4 +142,4 @@ if (isset($_REQUEST['version'])) {
}

// send it
sendImage($imgdata, $fmt, $thumbnail);
sendImage($imgdata, $fmt, $thumbnail);