Skip to content

Default console logging to stdout instead of stderr #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaskontrimas wants to merge 1 commit into from
Open

Default console logging to stdout instead of stderr #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skyllh/core/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def setup_logger(
The log level of the console handler. If None, it uses `log_level`.
stream : data stream | None
The stream to which the console handler will write.
If None, it defaults to `sys.stderr`.
If None, it defaults to `sys.stdout`.
log_file : str | None
If not ``None``, file handlers for DEBUG messages will be installed
and those messages will be stored in the given file.
Expand Down Expand Up @@ -131,7 +131,7 @@ def setup_logger(
else:
console_level = _resolve_log_level(console_level)
if stream is None:
stream = sys.stderr
stream = sys.stdout

# deduplicate StreamHandler targeting same stream
exists = any(
Expand Down
2 changes: 1 addition & 1 deletion tests/core/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def test_console_handlers(self):
self.assertEqual(logging.getLogger('skyllh').level, logging.INFO)
self.assertEqual(logging.getLogger(self.user_logger_name).level, logging.INFO)

# Redirect current console stderr stream to test stream.
# Redirect current console stream to test stream.
for logger_name in ('skyllh', self.user_logger_name):
lg = logging.getLogger(logger_name)
for handler in lg.handlers:
Expand Down
Loading