[HnR:4] Bulk checkpoint upsert API + reveal response fields#10150
Draft
karenrasmussen wants to merge 11 commits into
Draft
[HnR:4] Bulk checkpoint upsert API + reveal response fields#10150karenrasmussen wants to merge 11 commits into
karenrasmussen wants to merge 11 commits into
Conversation
Elimpizza
force-pushed
the
feat/bulk-checkpoint-upsert-api
branch
from
6b92a90 to
1d91f53
Compare
Elimpizza
force-pushed
the
checkpoint-reveal-response-fields
branch
from
50ae459 to
1977626
Compare
Elimpizza
changed the title
Elimpizza
changed the base branch from
feat/bulk-checkpoint-upsert-api
to
feat/checkpoint-merge-hook
Elimpizza
changed the title
Elimpizza
reviewed
Jul 3, 2026
Elimpizza
requested changes
Jul 3, 2026
| return ( | ||
| checkpoint is not None | ||
| and checkpoint.reveal_date is not None | ||
| and checkpoint.reveal_date <= datetime.now(tz=UTC) |
There was a problem hiding this comment.
Shouldn't we use naive sa.DateTime here? Also, the unit test test_it_includes_reveal_date in tests/unit/h/views/api/bulk/checkpoint_test.py:147-171 hides this because it mocks reveal_date as datetime(2026, 7, 1, 10, 0, 0, tzinfo=UTC)
Elimpizza
force-pushed
the
feat/checkpoint-merge-hook
branch
from
18362fb to
685059d
Compare
Elimpizza
force-pushed
the
checkpoint-reveal-response-fields
branch
from
d080cbb to
4d28fa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.