fix(deps): drop fast-xml-parser pin breaking the S3 deploy#7560
Merged
Conversation
The fast-xml-parser 5.7.0 resolution added in #7557 broke the client Release pipeline at 'Deploy to S3': @aws-sdk's XML response parser (fast-xml-parser 5.7.0) rejects the '
' entity in S3's XML reply ([EntityReplacer] Invalid character '#' in entity name: '#xD'). Deploy isn't in PR CI, so it passed review and only failed post-merge on main. fast-xml-parser here is deploy-tooling only (@aws-sdk in scripts/deploy-to-s3.js), not shipped. Its CVEs are in the XMLBuilder (write path, unused by @aws-sdk) or need untrusted XML input (@aws-sdk parses trusted S3 responses) -> LOW and not reachable. Reverting to the @aws-sdk-compatible 5.2.5 restores the working deploy; the proper long-term fix is bumping @aws-sdk itself. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7560 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 285 285
Lines 11971 11971
Branches 2920 2920
=======================================
Hits 11926 11926
Misses 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
santicomp2014
pushed a commit
that referenced
this pull request
Jul 1, 2026
Reverts the resolutions block to restore the last-known-good build output. #7557's build-tool pins (serialize-javascript v6->v7 etc.) changed the generated inline bootstrap script's bytes, so its sha256 no longer matched the CSP script-src hash allowlist the backend serves -> browser blocked the inline script -> broken client in production (CSP violation). Restores package.json + yarn.lock to 6307520 (pre-#7557). Security pins will be re-applied carefully, excluding the ones that alter build output / CSP hash. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken client Release pipeline (release-staging → Deploy to S3, run 28532169799).
#7557 added an unscoped
fast-xml-parser: 5.7.0resolution. @aws-sdk's XML response parser (inscripts/deploy-to-s3.js) chokes on the
entity in S3's XML reply with 5.7.0:The S3 upload itself returns HTTP 200 — only parsing the response fails. Deploy isn't part of PR CI, so this passed review and only surfaced post-merge on
main, blocking all client deploys.Why dropping the pin is safe
fast-xml-parseris deploy-tooling only (@aws-sdk, not shipped to the browser). Its CVEs are either in the XMLBuilder (write path — @aws-sdk only parses) or need untrusted XML input (@aws-sdk parses trusted S3 responses). So the finding is LOW and not reachable here. This reverts to5.2.5— the @aws-sdk-compatible version that deployed fine before #7557. All 25 other resolutions from #7557 are untouched.Proper long-term fix: bump @aws-sdk to a version bundling a fixed fast-xml-parser.
🤖 Generated with Claude Code