-
Notifications
You must be signed in to change notification settings - Fork 237
Fix: open as text link on downloads now uses utf-8 encoding #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
0eaaf0c
Fix: open as text link on downloads now uses utf-8 encoding
ArneBab 58077de
Fix: set utf-8 as fallback, as it should have been.
ArneBab 36359ef
Merge remote-tracking branch 'torusrxxx/patch-3' into open-as-plain-t…
ArneBab 827bec9
⬆️ Update Mockito to latest 2.x version
Bombe a72bc74
💚 Exclude ancient Hamcrest dependency from JUnit
Bombe 71b771f
✅ Add matchers for verifying links in HTML documents
Bombe bdfd1e3
✅ Add possibility to use different translation for each test
Bombe 322ff7f
✅ Add test implementation of ToadletContext
Bombe 5763d0e
🐛 Set charset correctly
Bombe b2c13f4
✅ Add matchers for TestToadletContext
Bombe ec7959d
✅ Add second test for FProxyToadlet
Bombe ada6f7e
✅ Allow TestToadletContext to execute the request itself
Bombe 68b73b0
✅ Add test for requesting an invalid key via parameter
Bombe ddf65d0
✅ Add test for requesting valid key via parameter
Bombe 0fa9dc0
✅ Add matcher for the HTML document of a toadlet context
Bombe 06758cb
✅ Add matchers for HTML
Bombe c167169
✅ Add test for / redirecting to welcome toadlet
Bombe 1e67343
✅ Add test for /favicon.ico redirect
Bombe 7c9e02a
✅ Add hasContentType matcher for TestToadletContext
Bombe cddc738
✅ Add test for feed generation
Bombe 65944c6
✨ Allow activating robots file generation in context
Bombe 1896e58
✅ Add tests for /robots.txt
Bombe c5bb0c5
✅ Add tests for some permanent redirects
Bombe b5f28eb
✨ Add Document matcher that can locate Elements
Bombe e8c58c3
✅ Add test for requesting a failed download
Bombe 1728fed
✨ Add Document matcher that can locate and verify Elements
Bombe e467ab1
✨ Add Element matcher that can verify attributes
Bombe c8c48e7
♻️ Use improved matchers
Bombe f55d7f5
✅ Add test for the progress page
Bombe 37ebe6b
✅ Add more tests for redirects
Bombe b567271
Merge remote-tracking branch 'Bombe/open-as-plain-text-utf8' into ope…
ArneBab 09eb720
Add jsoup verification key
ArneBab 556ca00
🧑💻 Make test (slightly) less confusing
Bombe cf65dd4
Merge remote-tracking branch 'Bombe/open-as-plain-text-utf8' into ope…
ArneBab 695c144
⬆️ Use jakarta activation-api instead of relying on javax.activation
Bombe e56bad8
Merge remote-tracking branch 'Bombe/open-as-plain-text-utf8' into ope…
ArneBab 3f0357a
Refresh the verification metadata
ArneBab ccf3694
Merge branch 'next' into open-as-plain-text-utf8
ArneBab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.