Repository navigation
fix: propagate compiler diagnostics to playground - #35
Merged
salaheldinsoliman merged 1 commit intoMay 17, 2026
Merged
salaheldinsoliman merged 1 commit into
salaheldinsoliman merged 1 commit into
Conversation
Contributor
|
Could you rebase the PR to develop? |
mohamedbasuony
force-pushed
the
fix/propagate-solang-errors-1898
branch
from
May 17, 2026 16:42
18b3581 to
fb96a85
Compare
Preserve Solang compiler diagnostics from compile failures and surface them through the playground UI instead of replacing them with generic errors. Keep successful compile behavior unchanged and preserve readable multiline diagnostic output for user-facing compiler errors. Signed-off-by: mohamedbasuony <mohamedbasuony@aucegypt.edu>
mohamedbasuony
force-pushed
the
fix/propagate-solang-errors-1898
branch
from
May 17, 2026 16:56
fb96a85 to
5d2cfaa
Compare
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1898 by preserving Solang compiler diagnostics through the playground compile flow.
Compiler diagnostics were being reduced before reaching the UI: the backend kept only the substring after the first lowercase
error:in compiler stderr, and the frontend displayed only one diagnostic field. This could hide warnings/context, multiline source spans, diagnostics without that exact marker, and useful fallback output.What changed
compile_stderr > compile_stdout > stderr > stdout > generic fallback.statusText.Verification
Ran locally:
git diff --checkrustfmt --check crates/backend/src/services/compile.rs crates/backend/src/services/sandbox.rscargo test -p backendcargo testnpm run build --workspace=packages/frontendManual Docker-backed check:
/compileand verified that the response preserves the compiler diagnostic text.npm run test --workspace=packages/apprequires a running server atlocalhost:9000; without that server it fails with connection errors.