Apply Basecoat to Quasar with basecoat.quasar.css#130
Apply Basecoat to Quasar with basecoat.quasar.css#130evnchn wants to merge 4 commits intohunvreus:developmentfrom
basecoat.quasar.css#130Conversation
docs: Add anchor tag to /kitchen-sink/#form
|
By the way: This came from zauberzeug/nicegui#5608 |
|
That's a pretty radical set of changes. I'm not opposed to it, but trying to understand if there's a common pattern with what others may need. Why do you need to move to using |
|
From how I see it, the value of Basecoat lies in 3:
While the combo works in its own right as a UI framework, the goal of this PR is to take (1) standalone, and apply it to other frameworks which may not use semantic HTML elements. For example, in Quasar, checkboxes / inputs are not visually achieved with an By using On the diff, yes it is big, but mostly it is moving stuff around. You can fact-check with Ctrl-F. If you need me to prove the equivalence do tell me. Note that some styles are not copied over because they are not generic ( And moving forward I see the Basecoat *: There is a |
|
To supplement some points.
We may want to hammer down which ones are considered "not generic" to move forward. I see padding, margin, width, height, and gap to be my preliminary candidate list, based on my current use case. However the list could forseeably grow and/or shrink.
While declaring them as public API is in my opinion best way to move forward, in case the developmental burden worries you, I also see no issues with prefixing them with either |
This PR applies Basecoat to Quasar with
basecoat.quasar.cssbasecoat.shared.cssand the originalbasecoat.cssas well as the newbasecoat.quasar.csswill import from it.basecoat.quasar.csstargets Quasar and applies Basecoatbasecoat.cdn.cssremains functionallly unchanged (very small diff, just moved around) for backwards compatibility (the intended goal)End user just has to do this to enjoy Basecoat styles in a Quasar application (using NiceGUI as an example, because that is what I made this for)
I am not sure whether to merge or to maintain this in a separate library. I am fine with either approach 😄