Enhanced query filter blocks [rebased and updated]#39
Merged
Conversation
goldenapples
force-pushed
the
enhanced-query-filter-blocks-updated
branch
3 times, most recently
from
167000c to
2ee049c
Compare
… direction - Updated package.json to include @wordpress/env as a dev dependency. - Added new attributes `displayType` and `layoutDirection` to block.json for post-type and taxonomy blocks. - Modified the Edit component for post-type and taxonomy blocks to include SelectControl for display type and ToggleGroupControl for layout direction. - Implemented conditional rendering for select, radio, and checkbox inputs based on the selected display type. - Updated render.php files for post-type and taxonomy blocks to handle new display type and layout direction attributes. - Added styles for radio and checkbox groups in style-index.css to support vertical and horizontal layouts. - refactor: Remove shared styles registration and update label classes in taxonomy render Build changes to render files
goldenapples
force-pushed
the
enhanced-query-filter-blocks-updated
branch
from
2ee049c to
f642d79
Compare
kadamwhite
approved these changes
Mar 24, 2026
kadamwhite
left a comment
kadamwhite
left a comment
Contributor
There was a problem hiding this comment.
The patch looks sensible and I didn't see any blocking issues while reviewing, 
!
Only called out a few areas where we could conceivably clean up apparently-duplicated UI and options code, and asked about whether the boolean tax query logic should be more explicitly spelled out in a comment.
Note: have not tested locally.
# Conflicts: # src/taxonomy/render.php
…ne post_type key sanitization In advanced query loop, if you selected multiple post types you would get no results because we were searching for a literal post type named "post,page". Within the sanitization logic, we were most of the way there but post types use sanitize_key on their name so this brings the input values closer in line with how a post type slug is stored in the DB
Contributor
|
I've resolved merge conflicts with
|
goldenapples
commented
Jun 23, 2026
goldenapples
left a comment
goldenapples
left a comment
Contributor
Author
There was a problem hiding this comment.
Updates look good, thank you for picking this up @kadamwhite !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #25 - this is the same branch, just cleaned up with phpcbf to follow the formatting standards of this project.
Original PR description: