Open
Conversation
ferdnyc
reviewed
Mar 26, 2026
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
41
| return ( | ||
| [ | ||
| x | ||
| for x in pathlib.Path("/etc/os-release").read_text().splitlines() | ||
| if x.startswith("ID=") | ||
| ][0] | ||
| .strip() | ||
| .replace("ID=", "") | ||
| .replace('"', "") | ||
| ) | ||
|
|
||
|
|
Comment on lines
+21
to
+22
| GDB_BINARY_PATH = which("gdb-multiarch") | ||
| RPYC_CONNECT_FAILURE_DELAY = 0.2 |
Comment on lines
13284
to
13290
| def target_remote_posthook(): | ||
| if gef.session.remote_initializing: | ||
| return | ||
| conn = gdb.selected_inferior().connection | ||
| if not isinstance(conn, gdb.RemoteTargetConnection): | ||
| raise TypeError("Expected type gdb.RemoteTargetConnection") | ||
| assert is_target_remote_or_extended(conn), "Target is not remote" | ||
| gef.session.remote = GefRemoteSessionManager(conn) | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR obsoletes
gef-remoteto be completely replaced by pre and post hooks ontarget remotedirectly.We use some heuristics to determine what type of remote we're connected to reliably.
In some old qemu, we still have to mock a memory layout, but the whole
syncthing is not necessary any longer.Fixes #1080
Fixes #1128
Checklist