fix: guard choices[0] and message=None before content access in llm_as_judge#1238
Open
qizwiz wants to merge 1 commit into
Open
fix: guard choices[0] and message=None before content access in llm_as_judge#1238qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
…s_judge OpenAI-compatible APIs can return empty choices on error or content filtering; Gemini returns choices[0].message=None on PROHIBITED_CONTENT (HTTP 200). Both cause unhandled exceptions inside the retry loop. Adds guard before response.choices[0].message.content in the API call retry path so the ValueError propagates cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
src/lighteval/metrics/utils/llm_as_judge.py, the API retry loop at line 439 accessesresponse.choices[0].message.contentwithout checking:choicesis non-empty (can be[]on API error or rate-limiting →IndexError)choices[0].messageis non-None (Gemini returnsNoneonPROHIBITED_CONTENTwith HTTP 200 →AttributeError)This fix adds the comprehensive guard:
The
ValueErroris caught by the innerexcept Exceptionblock that already handles API errors, so the retry logic continues as designed.Static analysis via pact (Z3 Fixedpoint datalog,
llm_response_unguardedrule); post-fix scan returns 0 violations.