Skip to content

fix: prevent IndexError in Doc.get_golds() for out-of-bounds gold_index #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmSach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent IndexError in Doc.get_golds() for out-of-bounds gold_index #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/lighteval/tasks/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,23 @@ class Doc:
num_samples: int = 1 # number of samples to generate for each sample
generation_grammar: None = None

def get_golds(self):
"""Return gold targets extracted from the target dict"""
def get_golds(self) -> list:
"""Return gold targets extracted from the target dict.

Returns:
list: The gold answer strings corresponding to gold_index indices.

Raises:
ValueError: If gold_index refers to an out-of-bounds choice index.
"""
gold_indices = as_list(self.gold_index)
golds = []
num_choices = len(self.choices)
for gold_ix in gold_indices:
if gold_ix >= num_choices:
raise ValueError(
f"gold_index {gold_ix} is out of bounds for choices of size {num_choices}"
)
golds.extend(as_list(self.choices[gold_ix]))
return golds

Expand Down